Marking translations as reviewed fails
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Ciencia_Al_Poder
	Jul 22 2022, 5:29 PM

Description

Steps to replicate the issue (include links if applicable):

Go to a translatable page, for example, https://www.mediawiki.org/wiki/Download
Click on the translate this page link, for example https://www.mediawiki.org/w/index.php?title=Special:Translate&group=page-Download&action=page&filter=
Select "Unreviewed" tab, then go to the bottom of the page and click the "Review" button on the right
Find one of the translated messages from the above list and click the "mark as reviewed" button on the right

What happens?:

A yellow background appears.

The message is never marked as reviewed.

Opening the error console, network tab, when clicking on "mark as reviewed", the server sends back a reply like this:

error Object { code: "internal_api_error_TypeError", info: "[f49cf0ba-4cf2-4de4-8080-63ad287aafd3] Caught exception of type TypeError", errorclass: "TypeError" }
servedby "mw1376"

What should have happened instead?:

The message should be marked as reviewed.

Software version Reproduced on www.mediawiki.org

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ReviewTranslationActionApi: Move to namespace and add strict types	mediawiki/extensions/Translate	wmf/1.39.0-wmf.21	+353 -301

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T182943 Move namespaced extensions to use PSR-4 autoloading
Open		None	T278278 Adopt PSR-4 namespaces in WMF-deployed extensions/skins
Open		None	T377752 Test coverage of root directories missing
Open		None	T193166 Adopt PSR-4 namespaces in Translate and modernize code
Resolved		Wangombe	T312008 Move classes under api folder to namespace
Resolved	PRODUCTION ERROR	abi_	T313608 Marking translations as reviewed fails

Event Timeline

Ciencia_Al_Poder created this task.Jul 22 2022, 5:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2022, 5:29 PM

Tacsipacsi changed the subtype of this task from "Bug Report" to "Production Error".Jul 22 2022, 5:40 PM

Tacsipacsi subscribed.

I was able to reproduce it locally using the currently deployed wmf/1.39.0-wmf.21 branch, but not the master branch. It looks like it’s been broken by 2e07010, but it has already been inadvertently fixed by 464a6d3, which is to be deployed next week (looks like it was a good idea @abi_ to remove the comment parameter for now). The full stack trace was:

TypeError at /var/www/html/wiki/includes/logging/ManualLogEntry.php(190)
from /var/www/html/wiki/includes/logging/ManualLogEntry.php(190)
#0 /var/www/html/wiki/extensions/Translate/api/ApiTranslationReview.php(101): ManualLogEntry->setComment(NULL)
#1 /var/www/html/wiki/extensions/Translate/api/ApiTranslationReview.php(57): ApiTranslationReview::doReview(User, MediaWiki\Revision\RevisionStoreRecord)
#2 /var/www/html/wiki/includes/api/ApiMain.php(1901): ApiTranslationReview->execute()
#3 /var/www/html/wiki/includes/api/ApiMain.php(875): ApiMain->executeAction()
#4 /var/www/html/wiki/includes/api/ApiMain.php(846): ApiMain->executeActionWithErrorHandling()
#5 /var/www/html/wiki/api.php(90): ApiMain->execute()
#6 /var/www/html/wiki/api.php(45): wfApiMain()
#7 {main}

Change 816272 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@wmf/1.39.0-wmf.21] ReviewTranslationActionApi: Move to namespace and add strict types

https://gerrit.wikimedia.org/r/816272

gerritbot added a project: Patch-For-Review.Jul 24 2022, 4:36 PM

abi_ claimed this task.Jul 24 2022, 4:36 PM

abi_ triaged this task as High priority.

abi_ added a project: Language-Team (Language-2022-July-September).

abi_ moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-July-September) board.

Change 816272 merged by jenkins-bot:

[mediawiki/extensions/Translate@wmf/1.39.0-wmf.21] ReviewTranslationActionApi: Move to namespace and add strict types

https://gerrit.wikimedia.org/r/816272

Mentioned in SAL (#wikimedia-operations) [2022-07-25T08:15:41Z] <kartik@deploy1002> Synchronized php-1.39.0-wmf.21/extensions/Translate: Backport: [[gerrit:816272|ReviewTranslationActionApi: Move to namespace and add strict types (T312008 T313608)]] (duration: 03m 09s)

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2022, 8:30 AM

Fix for this issue has been backported. It is now working as expected. Thanks you.

abi_ closed this task as Resolved.Jul 25 2022, 8:31 AM

abi_ moved this task from In Review to Done on the Language-Team (Language-2022-July-September) board.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 25 2022, 9:00 AM

Nikerabbit added a parent task: T312008: Move classes under api folder to namespace.Jul 28 2022, 8:30 AM

Nikerabbit mentioned this in T311567: ManualLogEntry::getComment() should always return string.Aug 26 2022, 3:25 PM

Marking translations as reviewed failsClosed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Related ObjectsSearch...

Event Timeline

Marking translations as reviewed fails
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Related Objects
Search...