Page MenuHomePhabricator

Table of contents icon looks misplaced with sticky table headers
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Screen Shot 2022-07-22 at 1.21.16 PM.png (291×839 px, 89 KB)

The table headings stick to the page, but look a little misplaced with the table of contents where it is.

What should have happened instead?:

Other information (browser name/version, screenshots, etc.):

Event Timeline

ovasileva triaged this task as Medium priority.Jul 26 2022, 2:57 PM

Change 816245 had a related patch set uploaded (by Jdlrobson; author: TheDJ):

[mediawiki/skins/Vector@master] Only apply sticky header offset if it is showing sticky

https://gerrit.wikimedia.org/r/816245

@alexhollender_WMF

Screen Shot 2022-07-26 at 9.27.43 PM.png (320×1 px, 83 KB)
is it okay for the new table of contents icon to overlap with sticky headers like so?
Screen Shot 2022-07-26 at 9.28.48 PM.png (716×1 px, 291 KB)

(please move to upcoming after answering)

@alexhollender_WMF is it okay for the new table of contents icon to overlap with sticky headers like so?

Screen Shot 2022-07-26 at 9.28.48 PM.png (716×1 px, 291 KB)

yes, that looks good to me. thanks

Can skip QA in beta cluster, but let's verify the fix next week (11th August 2022)

Change 816245 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Only apply sticky header offset if it is showing sticky

https://gerrit.wikimedia.org/r/816245

Looking good to me on Production. I tested on Windows across Edge, Firefox, Chrome, Opera, Yandex, and Internet Explorer. Tested on Mac across Safari, Firefox, Chrome, Opera, and Edge. I looked at both the desktop and mobile. Also, on iOS and Android, both phone and tablet devices. Everything looks good, the only exceptions are listed below. None of the headers are sticky on phone type devices, but I imagine that is by design.

On Internet Explorer 11, the header tables are not sticky for both the desktop and mobile versions of the article:

Screen Shot 2022-08-15 at 3.35.58 PM.png (1×2 px, 1 MB)

On Yandex 14.12, the header tables are not sticky and the mobile version is formatted a bit oddly:

Screen Shot 2022-08-15 at 3.47.12 PM.png (1×2 px, 2 MB)

Screen Shot 2022-08-15 at 3.35.58 PM.png (1×2 px, 1 MB)

ovasileva subscribed.

This looks okay to me. IE exceptions are expected. Thanks @ABorbaWMF!