Page MenuHomePhabricator

Make pagegenerators.PetScanPageGenerator a Generator
Closed, ResolvedPublicFeature

Description

Feature summary:
Make pagegenerators.PetScanPageGeneratora collections.Generator

Use case(s):
Currenly pagegenerators.PetScanPageGenerator is an Iterable; it works with for loops but it doest not support next() function. To convert it to an Iterator the iter() function must be used.

See also T312654

Benefits:
Making pagegenerators.PetScanPageGenerator a collections.abc.Generator it is capable to be used as

Iterable (for loops etc.)
Iterator (next() function etc.)
Generator (close() method which is used by BaseBot; BaseBot tries to convert every Iterable to a Generator)

Details

Event Timeline

Xqt changed the task status from Open to In Progress.Jul 24 2022, 9:00 AM
Xqt claimed this task.
Xqt triaged this task as Low priority.

Change 816290 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [IMPR] Make PetScanPageGenerator an abc.Generator

https://gerrit.wikimedia.org/r/816290

Change 816290 merged by jenkins-bot:

[pywikibot/core@master] [IMPR] Make PetScanPageGenerator an abc.Generator

https://gerrit.wikimedia.org/r/816290