Page MenuHomePhabricator

Highlight last element when shift tabbing
Closed, ResolvedPublic5 Estimated Story Points

Description

We separated highlighting (grey brackground color) and selection (blue background color) of parameters and in this tab changed the behaviour accordingly: Tab to first template parameter in list, not to the selection. But when shift tabbing the order of tabbing is reverse and instead of the first element we want to select the last one that is closer to the previous element and prevents a possibly big jump.

Peek 2022-07-25 10-05.gif (928×1 px, 184 KB)

Event Timeline

Change 816789 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Start with last item when shift+tabbing into parameter list

https://gerrit.wikimedia.org/r/816789

We should discuss if we want to live with the inconsistent behaviour of the current patch (when coming from the toolbar the first element is highlighted instead of the last), if we try to find a better solution or simply always highlight the first and live with a potential jump when shift-tabbing.

[…] inconsistent behaviour of the current patch (when coming from the toolbar the first element is highlighted instead of the last) […]

FYI, I managed to fix this in the patch.

Change 816789 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Start with last item when shift+tabbing into parameter list

https://gerrit.wikimedia.org/r/816789

thiemowmde set the point value for this task to 5.
thiemowmde moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2022-08-31 board.
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-08-31 board.