Page MenuHomePhabricator

UploadWizard: support previews with EXIF rotation
Closed, ResolvedPublic

Description

Author: neilk

Description:
UploadWizard is currently behind Special:Upload in one feature; for "instant" FileAPI thumbnails, image files which have an internal EXIF rotation setting are rotated in the browser using canvas.

Not applying this feature yet in UploadWizard, pending code cleanup.

See bug #6672 for more details and test file (attachment 8647).


Version: unspecified
Severity: normal

Details

Reference
bz29383

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:33 PM
bzimport added a project: UploadWizard.
bzimport set Reference to bz29383.

IMO showing an incorrectly rotated preview thumbnail is a regression; if I disable the fileApi support, I see a correctly-oriented thumbnail after upload. If I leave it on, I see an incorrectly-oriented thumbnail all the way through the process, until I arrive on the actual File page afterwards and discover it's been rotated back into place.

neilk wrote:

fixed in r90508, r90511 on trunk, r90568 on 1.18

The requisite jpegmeta library isn't in 1.17wmf1, so this has no effect in production now.

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:19 AM
Gilles added a project: Multimedia.
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:22 AM