DiscussionTools shows a regular topic as a template (coffee-roll) content
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	cooltey
	Jul 26 2022, 8:07 PM

Description

Steps to replicate the issue (include links if applicable):

Check the API here, the first section "Your recent edits" section title is shown in othercontent field.

Check the desktop user talk here, you will notice that the "Your recent edits" is a regular topic.

What happens?:

The "Your recent edits" shows as a template topic and shows twice in the API response.

What should have happened instead?:

It should show as a regular topic item instead.

Details

	Subject	Repo	Branch	Lines +/-
	API ThreadItemsHTML: improve generation of othercontent	mediawiki/extensions/DiscussionTools	master	+130 -59

Customize query in gerrit

Related Objects

Mentioned In: T310801: Determine if Coffee Roll on Talk Page should have an indicator to read more

Event Timeline

cooltey created this task.Jul 26 2022, 8:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2022, 8:07 PM

scblr mentioned this in T310801: Determine if Coffee Roll on Talk Page should have an indicator to read more.Jul 27 2022, 8:43 AM

Issue's that the code that builds othercontent isn't coping well with a completely empty first placeholder section, and is sucking in the HTML for the heading. Presumably because of an assumption somewhere that a nextSibling couldn't possible be outside the section.

Change 817816 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] API ThreadItemsHTML: only add initial placeholder if there's content

https://gerrit.wikimedia.org/r/817816

gerritbot added a project: Patch-For-Review.Jul 27 2022, 4:07 PM

DLynch moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Jul 27 2022, 4:15 PM

• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Jul 28 2022, 3:10 PM

It was actually more complicated than I thought. That patch (a) changes how the othercontent is generated to make it much less likely to pull in bits of the heading at the edge of the section, and (b) tries to only add the initial placeholder heading if there's content to put in it. (But it has a fairly expansive definition of "content".)

Change 817816 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] API ThreadItemsHTML: improve generation of othercontent

https://gerrit.wikimedia.org/r/817816

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Jul 28 2022, 10:00 PM

matmarex edited projects, added Skipped QA; removed Patch-For-Review.Jul 28 2022, 10:19 PM

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.

• ppelberg closed this task as Resolved.Jul 29 2022, 12:45 AM