Page MenuHomePhabricator
Create Task
Maniphest T313886

archivebot may fall into infinite loop
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue:
pwb archivebot -simulate user:miszaBot/config -lang:test -page:User_talk:DPL_bot

What happens?:
The bot loops infinitivly whil trying to find an archive page which is not full

Software version (skip for WMF-hosted wikis like Wikipedia):
Pywikibot 6.0.1+ but I guess also older releases are affected. Tested 6.0.1, 7.0.0, 7.4.0, 7.6.0

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[bugfix] raise MalformedConfigError if 'maxarchivesize' is 0pywikibot/coremaster+6 -1
[bugfix] Fix for DiscussionPage.size()pywikibot/coremaster+8 -2
Customize query in gerrit

Event Timeline

Xqt created this task.Jul 27 2022, 7:45 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJul 27 2022, 7:45 AM
Xqt changed the task status from Open to In Progress.Jul 27 2022, 7:46 AM
Xqt claimed this task.
Xqt triaged this task as Medium priority.
gerritbot added a comment.Jul 27 2022, 8:25 AM

Change 817716 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] use header length 0 if archive page does not exists

https://gerrit.wikimedia.org/r/817716

gerritbot added a project: Patch-For-Review.Jul 27 2022, 8:25 AM
Xqt updated the task description. (Show Details)Jul 27 2022, 11:56 AM
Xqt moved this task from Backlog to Needs Review on the Pywikibot board.Jul 27 2022, 12:33 PM
gerritbot added a comment.Jul 28 2022, 12:17 PM

Change 817716 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] Fix for DiscussionPage.size()

https://gerrit.wikimedia.org/r/817716

Maintenance_bot removed a project: Patch-For-Review.Jul 28 2022, 12:30 PM
Xqt added a comment.Jul 28 2022, 1:21 PM

There is a similar problem when maxarchivesize = 0T
https://test.wikipedia.org/w/index.php?title=User_talk:Ignocrates&action=history

btw. the units are not described on script's documentation

Xqt changed the task status from In Progress to Open.Jul 29 2022, 8:11 AM
Xqt removed Xqt as the assignee of this task.
Xqt moved this task from Backlog to Bug Report on the Pywikibot-archivebot.py board.Aug 5 2022, 7:01 PM
Xqt raised the priority of this task from Medium to High.Aug 5 2022, 7:05 PM
matej_suchanek subscribed.Aug 7 2022, 9:16 AM
In T313886#8111808, @Xqt wrote:

There is a similar problem when maxarchivesize = 0T

That makes no sense. What about raising an exception on the encounter (during the validation)?

Xqt changed the task status from Open to In Progress.Aug 7 2022, 11:25 AM
Xqt claimed this task.
gerritbot added a comment.Aug 7 2022, 11:28 AM

Change 820865 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] raise MalformedConfigError if 'maxarchivesize' is 0

https://gerrit.wikimedia.org/r/820865

gerritbot added a project: Patch-For-Review.Aug 7 2022, 11:28 AM
Xqt moved this task from Bug Report to Needs Review on the Pywikibot-archivebot.py board.Aug 7 2022, 12:11 PM
gerritbot added a comment.Aug 7 2022, 1:59 PM

Change 820865 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] raise MalformedConfigError if 'maxarchivesize' is 0

https://gerrit.wikimedia.org/r/820865

Maintenance_bot removed a project: Patch-For-Review.Aug 7 2022, 2:30 PM
Xqt closed this task as Resolved.Aug 7 2022, 9:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits