Page MenuHomePhabricator

🥔️ Create e2e tests for authenticated edits
Closed, ResolvedPublic

Description

These tests should check that requests made with our existing POST/PUT/DELETE are associated with the right user.

Event Timeline

Notes from task breakdown:

Task 1: create RequestBuilder.withUser( user ) - @Ollie.Shotton_WMDE creates task

  • create a RequestBuilder.withUser( user ) method where user is something like the return value of await action.mindy()
  • use it in the 'has an X-Authenticated-User header with the logged in user' test cases

Task 2: add missing AddItemStatementTest for authenticated edit (user shows up in edit metadata) - @Silvan_WMDE creates task

  • create the missing test case in AddItemStatementTest.js
  • we want to avoid creating multiple user per test suite to save time

Task 3: extract auth tests into separate file - @Jakob_WMDE creates task

  • extract all auth tests into a separate test file instead of repeating them for every route test suite
  • similar to conditional request tests
Jakob_WMDE renamed this task from Create e2e tests for authenticated edits to 🥔️ Create e2e tests for authenticated edits.Jul 27 2022, 1:01 PM

@Jakob_WMDE: Assuming this task is resolved. Thus setting resolved task status. Please reopen and add an active project tag if that is not the case. Thanks.