Page MenuHomePhabricator

Include the story viewer in the navigation stack
Closed, ResolvedPublic

Description

Background

Including the StoryViewer in the navigation stack means it can be closed with the browser back button, among other things.

Consider this example

  1. Go to Wikipedia Cat article
  2. Click on a link inside the article to go to the Lion article
  3. The Lion article has stories. Click on a story to open the viewer
  4. Click the browser back button
    1. The viewer closes and you stay on the Lion article (because it is included in the browser navigation stack) OR
    2. You go back to the Cat article (it is indeed the previous page from the browser's perspective and the viewer being just a popup is not part of the navigation stack)

If we go with option A, there are more questions about whether viewing several stories represent several navigation entries or the same one.

Decision

Based on our discussion, we are going ahead with the option A as its possible readers might be interested to learn more about the article after going through stories, media viewer also has a similar behavior on our platforms. Viewing several stories can represent same navigation so click on back button from any story would lead to the article.

Event Timeline

To me, option A looks better approach to deal with back button as its possible readers might be interested to learn more about the article after going through stories. Viewing several stories can represent same navigation so click on back button from any story would lead to the article itself.

@SBisson on mobile, device back key is what we refer to browser back button right?

To me, option A looks better approach to deal with back button as its possible readers might be interested to learn more about the article after going through stories. Viewing several stories can represent same navigation so click on back button from any story would lead to the article itself.

That makes sense. This is what the Media Viewer does as well.

@SBisson on mobile, device back key is what we refer to browser back button right?

Yes

SBisson renamed this task from Should the story viewer be in the navigation stack? to Include the story viewer in the navigation stack.Aug 10 2022, 12:46 PM
SBisson triaged this task as Medium priority.Aug 10 2022, 1:09 PM

Change 823646 had a related patch set uploaded (by Aklapper; author: Huei Tan):

[mediawiki/extensions/Wikistories@master] Include the story viewer in the navigation stack

https://gerrit.wikimedia.org/r/823646

Change 823646 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Include the story viewer in the navigation stack

https://gerrit.wikimedia.org/r/823646

EUdoh-WMF subscribed.

Tested and passed.

The "Back" button goes back a previous screen between unique URLs.

  1. If story viewer was opened and then story builder (through "Edit"), it goes back to story viewer. Navigating "Back" again returns to the Wiki page.