Page MenuHomePhabricator
Create Task
Maniphest T313928

🥔️ Extract auth tests into a file
Closed, ResolvedPublic
Actions

Description

  • extract all authentication and authorization tests into a separate test file instead of repeating them for every route test suite
  • similar to conditional request tests

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
REST: Extract authorization tests into a single filemediawiki/extensions/Wikibasemaster+50 -141
REST: Extract authentication tests into a single filemediawiki/extensions/Wikibasemaster+132 -294
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Jul 27 2022, 2:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2022, 2:16 PM
Jakob_WMDE claimed this task.Aug 4 2022, 2:30 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 11) board.
gerritbot added a comment.Aug 5 2022, 8:46 AM

Change 820655 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Extract auth tests into a single test file

https://gerrit.wikimedia.org/r/820655

gerritbot added a project: Patch-For-Review.Aug 5 2022, 8:46 AM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 11) board.Aug 5 2022, 9:02 AM
Jakob_WMDE moved this task from Peer Review to Doing on the Wikibase Product Platform (v1) (Sprint 11) board.Aug 5 2022, 9:23 AM
gerritbot added a comment.Aug 5 2022, 10:38 AM

Change 820692 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Extract authorization tests into a single file

https://gerrit.wikimedia.org/r/820692

gerritbot added a comment.Aug 5 2022, 11:40 AM

Change 820655 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Extract authentication tests into a single file

https://gerrit.wikimedia.org/r/820655

gerritbot added a comment.Aug 5 2022, 11:45 AM

Change 820692 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Extract authorization tests into a single file

https://gerrit.wikimedia.org/r/820692

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 5 2022, 12:00 PM
Jakob_WMDE moved this task from Doing to Done on the Wikibase Product Platform (v1) (Sprint 11) board.Aug 5 2022, 12:02 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 5 2022, 12:30 PM
Aklapper closed this task as Resolved.Oct 10 2022, 9:53 AM

@Jakob_WMDE: Assuming this task is resolved. Thus setting resolved task status. Please reopen and add an active project tag if that is not the case. Thanks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits