Page MenuHomePhabricator

Ensure phab1004/phab2002 are scap3 targets
Closed, ResolvedPublic3 Estimated Story Points

Description

Once scap3 deployment to phab2001 is tested and working, we should ensure the new hosts are working targets as well.

Event Timeline

brennen set the point value for this task to 3.Jul 27 2022, 5:12 PM
Dzahn renamed this task from Ensure phab1002/phab2002 are scap3 targets to Ensure phab1004/phab2002 are scap3 targets.Aug 22 2022, 6:10 PM

Since changes last Friday (https://gerrit.wikimedia.org/r/q/topic:phab2002) allowed https://gerrit.wikimedia.org/r/c/operations/puppet/+/823636 phab2002 should now technically be a scap::target. Because the role was applied.

[phab2002:~] $ which scap
/usr/bin/scap

Change 832282 had a related patch set uploaded (by Dduvall; author: Dduvall):

[phabricator/deployment@wmf/stable] scap: Target only phab2002.codfw.wmnet for now

https://gerrit.wikimedia.org/r/832282

Change 832282 merged by Dduvall:

[phabricator/deployment@wmf/stable] scap: Target only phab2002.codfw.wmnet for now

https://gerrit.wikimedia.org/r/832282

Change 832291 had a related patch set uploaded (by Dduvall; author: Dduvall):

[mediawiki/tools/scap@master] checks: Avoid TypeError exception during check execution

https://gerrit.wikimedia.org/r/832291

Change 832291 merged by jenkins-bot:

[mediawiki/tools/scap@master] checks: Avoid TypeError exception during check execution

https://gerrit.wikimedia.org/r/832291

Change 852965 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[phabricator/deployment@wmf/stable] scap targets: add phab1004.eqiad.wmnet

https://gerrit.wikimedia.org/r/852965

Change 852965 merged by Brennen Bearnes:

[phabricator/deployment@wmf/stable] scap targets: add phab1004.eqiad.wmnet

https://gerrit.wikimedia.org/r/852965

@brennen The difference I was describing I see between phab2002 and phab1004 is, when I run puppet there are no errors on phab2002 but on phab1004 there is:

Error: Execution of '/usr/bin/scap deploy-local --repo phabricator/deployment -D log_json:False' returned 1: 
Error: /Stage[main]/Phabricator/Scap::Target[phabricator/deployment]/Package[phabricator/deployment]/ensure: change from 'absent' to 'present' failed: Execution of '/usr/bin/scap deploy-local --repo phabricator/deployment -D log_json:False' returned 1: 
Notice: /Stage[main]/Phabricator/File[/srv/phab]: Dependency Package[phabricator/deployment] has failures: true

And then other stuff is just dependent on that. So I would expect that to go away after an initial deploy there.

@brennen This is confirmation that the host only gets slave / readonly db access:

root@phab1004:/etc/phabricator# grep -r m3 *
config.yaml:    database_host: m3-slave.eqiad.wmnet
config.yaml:    database_host: m3-slave.eqiad.wmnet

on phab1001 that is m3-master in the same place.

I confirm puppet errors regarding initial deployment are gone after Brennen deployed.

Due to fixed dependency errors puppet could then finish other parts of the setup.

Related commit 5d4beebc pushed by brennen (author: Dan Duvall):

[ repos/phabricator/deployment@wmf/stable ] scap: Target only phab2002.codfw.wmnet for now

Related commit b3d114e1 pushed by brennen (author: Brennen Bearnes):

[ repos/phabricator/deployment@wmf/stable ] scap targets: add phab1004.eqiad.wmnet