beau wrote:

Patch to add meta=proofreadinfo

Sample output:

<?xml version="1.0"?>
<api xmlns="http://www.mediawiki.org/xml/api/">

<query>
  <proofreadnamespaces>
    <index id="102" />
    <page id="100" />
  </proofreadnamespaces>
  <proofreadqualitylevels>
    <level id="0" category="Bez treści" />
    <level id="1" category="Nieskorygowana" />
    <level id="2" category="Problemy" />
    <level id="3" category="Skorygowana" />
    <level id="4" category="Uwierzytelniona" />
  </proofreadqualitylevels>
</query>

</api>

Attached:

Really proofread page should do namespaces itself in the same way that liquidThreads makes its own thread namespace (imho)...

Also, having namespace configuration inside the mediawiki namespace is really icky, it should be a $wgGlobalVariable (That has nothing to do with your patch, I'm just saying...)

john wrote:

Patch applied in r95351. A few notes though

+ if ($namespace != null) {

Our coding conventions prefer spaces (http://www.mediawiki.org/wiki/Coding_convention#Spaces) inside of parentheses. Also, when checking if a value is null you should use an identical comparison operator, just to be safe (http://www.mediawiki.org/wiki/Coding_convention#PHP_pitfalls)

I also swapped out the foreach+switch statement in the api module for a simpler if statement.

+ ApiBase::dieDebug( METHOD, "Unknown prop=$p" );

You don't have to worry about these things, the API will throw a warning about it and remove it from the array :)

Also in the append functions I removed the $property argument, because it was unused.

Very good patch though Beau, thank you for taking the time to do this. :)

beau wrote:

(In reply to comment #2)

Really proofread page should do namespaces itself in the same way that
liquidThreads makes its own thread namespace (imho)...

Also, having namespace configuration inside the mediawiki namespace is really
icky, it should be a $wgGlobalVariable (That has nothing to do with your patch,
I'm just saying...)

It makes writing bots/scripts which would work on more than one project a pain. I have already thought about fixing that using LiquidThreads approach at some point, however I prefer to solve all trivial bugs first ;-).