Page MenuHomePhabricator
Create Task
Maniphest T313990

[Regression] Special:LinkSearch should not submit 'title' parameter twice
Closed, ResolvedPublic
Actions

Description

  1. https://en.wikipedia.org/w/index.php?title=Special:LinkSearch
  2. Enter https://php.net
  3. submit "Search".

Actual:

https://en.wikipedia.org/w/index.php?title=Special%3ALinkSearch&target=https%3A%2F%2Fphp.net&title=Special%3ALinkSearch

Screenshot 2022-07-27 at 14.04.36.png (1×2 px, 603 KB)

Expected:

https://en.wikipedia.org/w/index.php?title=Special:LinkSearch&target=https%3A%2F%2Fphp.net

Details

SubjectRepoBranchLines +/-
Fix some special pages submitting 'title' parameter twicemediawiki/coremaster+2 -10
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jul 27 2022, 9:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2022, 9:07 PM
Krinkle renamed this task from Special:LinkSearch submits 'title' parameter twice to [Regression] Special:LinkSearch should not submit 'title' parameter twice.Jul 27 2022, 9:07 PM
matmarex subscribed.Jul 27 2022, 9:34 PM

Might be caused by rMWef2e948d31d9: HTMLForm: Add title field if the action is overridden to script path, that patch fixed similar issues in some other forms, but missed this one.

matmarex claimed this task.Jul 27 2022, 9:37 PM
gerritbot added a comment.Jul 27 2022, 9:37 PM

Change 817904 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Fix some special pages submitting 'title' parameter twice

https://gerrit.wikimedia.org/r/817904

gerritbot added a project: Patch-For-Review.Jul 27 2022, 9:37 PM
gerritbot added a comment.Jul 27 2022, 10:41 PM

Change 817904 merged by jenkins-bot:

[mediawiki/core@master] Fix some special pages submitting 'title' parameter twice

https://gerrit.wikimedia.org/r/817904

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Jul 27 2022, 11:00 PM
matmarex closed this task as Resolved.Jul 27 2022, 11:13 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 27 2022, 11:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL