Vector2022 menu tabs in Wikisource show triplicated icons (due to lack of background-repeat: no-repeat)
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Ruthven
	Jul 28 2022, 9:07 AM

Description

Steps to replicate the issue (include links if applicable):

Go to https://nap.wikisource.org/w/index.php?title=Paggena:No_brigantaggio_de_femmene_(1867).djvu/5&action=edit&useskin=vector-2022

or select you preferred Wikisource project having Vector 2022 installed and

Open a Page namespace under Vector 2022 skin (or simply add &useskin=vector-2022 at the end of the URL)
Edit it (don't forget to add &useskin=vector-2022 at the end of the URL if you've not selected the skin in the preferences)
Look at the toolbar above (namely navigation toolbar tagged class="vector-article-toolbar")

What happens?:
There is a double toolbar (and some weird misaligned words on the side)
See the screenshot below

Screenshot from 2022-07-28 10-47-05.png (829×1 px, 275 KB)

Other information (browser name/version, screenshots, etc.):
Using Version 97.0.4692.99 (Official Build) (64-bit) under Ubuntu 20.04

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	styles: Set `background-repeat: no-repeat` for menu tabs	mediawiki/skins/Vector	master	+2 -0
	Specify background-repeat on icons	mediawiki/extensions/ProofreadPage	master	+3 -0

Customize query in gerrit

Event Timeline

Ruthven created this task.Jul 28 2022, 9:07 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2022, 9:07 AM

Reboot01 subscribed.Jul 29 2022, 4:31 PM

Hi @Ruthven, thanks for taking the time to report this!
This happens because in Vector 2022, .vector-menu-tabs .mw-list-item > a has no background-repeat: no-repeat; (while classic Vector has) in the source file resources/skins.vector.styles/components/MenuTabs.less in the mediawiki/skins/Vector code repository

Aklapper renamed this task from Double toolbar in Wikisource under Vector2022 to Vector2022 menu tabs in Wikisource show triplicated icons (due to lack of background-repeat: no-repeat).Aug 3 2022, 11:14 AM

Change 820108 had a related patch set uploaded (by Aklapper; author: Aklapper):

[mediawiki/skins/Vector@master] Set background-repeat: no-repeat for menu tabs

https://gerrit.wikimedia.org/r/820108

gerritbot added a project: Patch-For-Review.Aug 3 2022, 11:45 AM

Ruthven awarded a token.Aug 3 2022, 5:37 PM

Change 820108 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Set `background-repeat: no-repeat` for menu tabs

https://gerrit.wikimedia.org/r/820108

Maintenance_bot removed a project: Patch-For-Review.Aug 4 2022, 12:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 4 2022, 1:00 PM

Change 820517 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ProofreadPage@master] Specify background-repeat on icons