Authentication comes for free via the framework, but authorization for PUT requests needs to be implemented on the use case level:
- check in use case via PermissionChecker
- create tests for both route handlers
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T335067 Epic: Wikidata Query Service stabilization | |||
| Resolved | Lydia_Pintscher | T314503 rollout of the new Wikibase REST API to Wikidata | |||
| Invalid | None | T301860 Enable reading and modifying a statement of item or property using REST API | |||
| Resolved | None | T312748 🟦️ Authenticate and authorize as mediawiki user when making DELETE and PUT requests to REST API statement routes | |||
| Resolved | Jakob_WMDE | T314031 🟦️ Check authorization for PUT statement requests |
Event Timeline
Comment Actions
Change 819496 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Wikibase@master] REST: Extract protectItem test helper
Comment Actions
Change 819579 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Wikibase@master] REST: Add authorization check to ReplaceItemStatement
Comment Actions
Change 819587 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Wikibase@master] REST: Extract frameworkish permission error creation
Comment Actions
Change 819496 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] REST: Extract protectItem test helper
Comment Actions
Change 819579 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] REST: Add authorization check to ReplaceItemStatement
Comment Actions
Change 819587 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] REST: Extract frameworkish permission error creation
Comment Actions
@Jakob_WMDE: Assuming this task is resolved. Thus setting resolved task status. Please reopen and add an active project tag if that is not the case. Thanks.