Page MenuHomePhabricator
Create Task
Maniphest T314058

TypeError: Argument 1 passed to Flow\Hooks::onSpecialCheckUserGetLinksFromRow() must be SpecialPage, CheckUserGetEditsPager given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 1 passed to Flow\Hooks::onSpecialCheckUserGetLinksFromRow() must be an instance of SpecialPage, instance of MediaWiki\CheckUser\CheckUserPagers\CheckUserGetEditsPager given, called in /srv/mediawiki/php-1.39
exception.trace
from /srv/mediawiki/php-1.39.0-wmf.22/extensions/Flow/includes/Hooks.php(517)
#0 /srv/mediawiki/php-1.39.0-wmf.22/includes/HookContainer/HookContainer.php(338): Flow\Hooks::onSpecialCheckUserGetLinksFromRow(MediaWiki\CheckUser\CheckUserPagers\CheckUserGetEditsPager, stdClass, array)
#1 /srv/mediawiki/php-1.39.0-wmf.22/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#2 /srv/mediawiki/php-1.39.0-wmf.22/includes/Hooks.php(137): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#3 /srv/mediawiki/php-1.39.0-wmf.22/extensions/CheckUser/src/CheckUserPagers/CheckUserGetEditsPager.php(347): Hooks::run(string, array)
#4 /srv/mediawiki/php-1.39.0-wmf.22/extensions/CheckUser/src/CheckUserPagers/CheckUserGetEditsPager.php(136): MediaWiki\CheckUser\CheckUserPagers\CheckUserGetEditsPager->getLinksFromRow(stdClass)
#5 /srv/mediawiki/php-1.39.0-wmf.22/includes/pager/ReverseChronologicalPager.php(115): MediaWiki\CheckUser\CheckUserPagers\CheckUserGetEditsPager->formatRow(stdClass)
#6 /srv/mediawiki/php-1.39.0-wmf.22/includes/pager/IndexPager.php(634): ReverseChronologicalPager->getRow(stdClass)
#7 /srv/mediawiki/php-1.39.0-wmf.22/extensions/CheckUser/src/Specials/SpecialCheckUser.php(681): IndexPager->getBody()
#8 /srv/mediawiki/php-1.39.0-wmf.22/extensions/CheckUser/src/Specials/SpecialCheckUser.php(285): MediaWiki\CheckUser\Specials\SpecialCheckUser->doIPEditsRequest(string, boolean)
#9 /srv/mediawiki/php-1.39.0-wmf.22/includes/specialpage/SpecialPage.php(690): MediaWiki\CheckUser\Specials\SpecialCheckUser->execute(NULL)
#10 /srv/mediawiki/php-1.39.0-wmf.22/includes/specialpage/SpecialPageFactory.php(1423): SpecialPage->run(NULL)
#11 /srv/mediawiki/php-1.39.0-wmf.22/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#12 /srv/mediawiki/php-1.39.0-wmf.22/includes/MediaWiki.php(911): MediaWiki->performRequest()
#13 /srv/mediawiki/php-1.39.0-wmf.22/includes/MediaWiki.php(568): MediaWiki->main()
#14 /srv/mediawiki/php-1.39.0-wmf.22/index.php(50): MediaWiki->run()
#15 /srv/mediawiki/php-1.39.0-wmf.22/index.php(46): wfIndexMain()
#16 /srv/mediawiki/w/index.php(3): require(string)
#17 {main}
Notes
  • Seems new in 1.39.0-wmf.22
  • Only 3 instances since deploying to group1 yesterday
  • All on commonswiki

Details

Request URL
https://commons.wikimedia.org/wiki/Special:CheckUser
SubjectRepoBranchLines +/-
Update CheckUser hook for paginationmediawiki/extensions/Flowmaster+3 -3
Update CheckUser hook for paginationmediawiki/extensions/Flowwmf/1.39.0-wmf.22+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Jul 28 2022, 3:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2022, 3:21 PM
thcipriani moved this task from Untriaged to Jul 2022 on the Wikimedia-production-error board.Jul 28 2022, 3:21 PM
Zabe merged a task: T314069: Fatal exception of type "TypeError" when using checkuser "Get edits" on Wikidata .Jul 28 2022, 4:44 PM
Zabe added subscribers: alaa, Zabe.
gerritbot added a comment.Jul 28 2022, 4:44 PM

Change 818181 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Flow@master] Update CheckUser hook for pagination

https://gerrit.wikimedia.org/r/818181

gerritbot added a project: Patch-For-Review.Jul 28 2022, 4:44 PM
Zabe added a comment.Jul 28 2022, 4:51 PM

caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/814006

brennen subscribed.Jul 28 2022, 5:29 PM

@Zabe - pretty low rate on this one, is there any reason to block on above?

Zabe added a comment.Jul 28 2022, 5:37 PM
In T314058#8112833, @brennen wrote:

@Zabe - pretty low rate on this one, is there any reason to block on above?

The impact of this is that every time a check user does a 'get edits' on a user or an ip on a wiki with Flow enabled it will fatal. Most wikis where this is happens are in group2, so I would prefer to get this fix deployed before the train rolls forward, in order to prevent some CU's not being capable of doing their work on some wikis.

Zabe added a parent task: T308075: 1.39.0-wmf.22 deployment blockers.Jul 28 2022, 5:43 PM
Agusbou2015 subscribed.Jul 28 2022, 5:59 PM
Zabe triaged this task as Unbreak Now! priority.Jul 28 2022, 6:07 PM
gerritbot added a comment.Jul 28 2022, 6:45 PM

Change 818181 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Update CheckUser hook for pagination

https://gerrit.wikimedia.org/r/818181

gerritbot added a comment.Jul 28 2022, 6:46 PM

Change 818154 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Flow@wmf/1.39.0-wmf.22] Update CheckUser hook for pagination

https://gerrit.wikimedia.org/r/818154

gerritbot added a comment.Jul 28 2022, 7:23 PM

Change 818154 merged by jenkins-bot:

[mediawiki/extensions/Flow@wmf/1.39.0-wmf.22] Update CheckUser hook for pagination

https://gerrit.wikimedia.org/r/818154

Maintenance_bot removed a project: Patch-For-Review.Jul 28 2022, 7:30 PM
Stashbot added a comment.Jul 28 2022, 7:34 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-28T19:34:33Z] <brennen@deploy1002> Synchronized php-1.39.0-wmf.22/extensions/Flow: Backport: [[gerrit:818154|Update CheckUser hook for pagination (T314058 T314069)]] (duration: 03m 16s)

Stashbot mentioned this in T314069: Fatal exception of type "TypeError" when using checkuser "Get edits" on Wikidata .Jul 28 2022, 7:34 PM
brennen closed this task as Resolved.Jul 28 2022, 7:36 PM
brennen claimed this task.
Zabe claimed this task.Jul 28 2022, 9:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL