Page MenuHomePhabricator

Add metadata dialog to ZFunctionTesterReport component & remove current metadata display items
Closed, ResolvedPublic

Description

Currently the ZFunctionTesterReport component shows tester status, run duration, and failure reason (sometimes) for the currently selected tester. Now that we have the metadata map available, we can show all of the available metadata by popping up the metadata dialog, and make this component more consistent with the presentation designed for the function implementation table (T310161), for which the implementation is currently underway.

Alternatively, arrange for activeTesterFailReason to return expected and actual values. The following, currently broken, code (removed from there) could be reused:

			expected = this.zObjectToString( reason[ 0 ] );
			actual = this.zObjectToString( reason[ 1 ] );

			return this.$i18n( 'wikilambda-tester-failure-expected' ).text() + ' ' +
				expected + '. ' +
				this.$i18n( 'wikilambda-tester-failure-actual' ).text() + ' ' +
				actual + '.';

Note: It's my understanding the use of ZFunctionTesterReport will be phased out over time, but the phaseout could take quite a while.

Event Timeline

DMartin-WMF renamed this task from Add metadata dialog to ZFunctionTesterReport component to Add metadata dialog to ZFunctionTesterReport component & remove current metadata display items.Jul 28 2022, 6:57 PM

Change 819778 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Add metadata dialog to ZFunctionTesterReport component

https://gerrit.wikimedia.org/r/819778

Change 819778 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add metadata dialog to ZFunctionTesterReport component

https://gerrit.wikimedia.org/r/819778

Reopening. Before closing this, figure out why the metadata dialog for the failing case here:

http://localhost:8080/wiki/Z801?view=zobject-viewer

is not showing validator errors, actual and expected values.

Oops, my previous comment was born of confusion. The validator errors, actual and expected values will be there once

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/826692/1

has been merged. Re-closing.