Page MenuHomePhabricator

PHP 8.2: ${var} style string interpolation is deprecated
Open, Needs TriagePublic

Description

Per https://github.com/php/php-src/blob/1a9e689/UPGRADING:

The "${var}" and "${expr}" style string interpolations are deprecated and
will be removed in PHP 9. Use "$var"/"{$var}" or "{${expr}}", respectively.
RFC: https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation

Usages in core and extensions will need to be migrated accordingly.

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/CirrusSearchREL1_42+3 -3
mediawiki/extensions/CirrusSearchmaster+3 -3
mediawiki/extensions/WikibaseREL1_41+1 -1
mediawiki/extensions/TimedMediaHandlermaster+1 -1
mediawiki/extensions/TimedMediaHandlerREL1_41+1 -1
mediawiki/vendormaster+1 K -844
mediawiki/extensions/Wikibasemaster+1 -1
mediawiki/services/parsoidmaster+1 -1
mediawiki/extensions/LabeledSectionTransclusionREL1_39+1 -1
operations/puppetproduction+13 -11
mediawiki/tools/codesniffermaster+244 -5
mediawiki/coremaster+1 -1
mediawiki/coreREL1_39+1 -1
mediawiki/coremaster+2 -2
mediawiki/vendormaster+25 -25
mediawiki/coreREL1_39+3 -2
mediawiki/vendorREL1_39+21 -21
mediawiki/coremaster+2 -1
mediawiki/extensions/MathSearchmaster+10 -10
mediawiki/extensions/JsonDatamaster+5 -5
mediawiki/extensions/BlueSpiceAvatarsmaster+1 -1
mediawiki/coremaster+1 -1
mediawiki/extensions/DynamicPageListmaster+5 -5
mediawiki/extensions/Html2Wikimaster+1 -1
mediawiki/extensions/Mementomaster+7 -7
mediawiki/extensions/PwnedPasswordsmaster+1 -1
mediawiki/libs/RemexHtmlmaster+1 -1
mediawiki/vendorwmf/1.40.0-wmf.12+3 K -48 K
mediawiki/vendormaster+3 K -48 K
mediawiki/extensions/MathREL1_39+3 -3
mediawiki/extensions/WikibaseQualityConstraintsmaster+3 -3
mediawiki/extensions/CentralNoticemaster+1 -1
mediawiki/extensions/DiscussionToolsmaster+1 -1
mediawiki/extensions/CirrusSearchmaster+2 -2
mediawiki/extensions/Wikibasemaster+6 -6
mediawiki/extensions/WikibaseLexememaster+2 -2
mediawiki/extensions/CirrusSearchmaster+20 -20
mediawiki/extensions/LabeledSectionTransclusionmaster+1 -1
mediawiki/services/parsoidmaster+10 -10
mediawiki/extensions/GrowthExperimentsmaster+27 -27
mediawiki/extensions/Mathmaster+3 -3
mediawiki/coreREL1_39+1 -1
mediawiki/extensions/TextExtractsREL1_39+1 -1
mediawiki/coremaster+1 -1
mediawiki/extensions/ReadingListsmaster+7 -7
mediawiki/extensions/ORESmaster+6 -6
mediawiki/extensions/TextExtractsmaster+1 -1
mediawiki/coremaster+1 -1
mediawiki/extensions/CodeReviewmaster+1 -1
mediawiki/coreREL1_39+5 -0
mediawiki/extensions/CiteThisPagemaster+4 -4
mediawiki/libs/XMPReader0.8.x+1 -1
mediawiki/extensions/TimedMediaHandlermaster+1 -1
mediawiki/extensions/CiteThisPageREL1_39+4 -4
mediawiki/extensions/EventBusmaster+1 -1
mediawiki/extensions/ProofreadPagemaster+2 -2
mediawiki/skins/MinervaNeueREL1_39+1 -1
mediawiki/extensions/ActiveAbstractmaster+1 -1
mediawiki/extensions/GettingStartedmaster+1 -1
mediawiki/skins/MinervaNeuemaster+1 -1
mediawiki/services/parsoidmaster+1 -1
mediawiki/libs/XMPReadermaster+1 -1
mediawiki/coreREL1_37+21 -21
mediawiki/coreREL1_35+16 -16
mediawiki/coreREL1_38+22 -22
mediawiki/coremaster+24 -24
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 853461 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Math@master] DeclhTest: Fix string interpolation

https://gerrit.wikimedia.org/r/853461

Change 853461 merged by jenkins-bot:

[mediawiki/extensions/Math@master] DeclhTest: Fix string interpolation

https://gerrit.wikimedia.org/r/853461

Change 853433 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Math@REL1_39] DeclhTest: Fix string interpolation

https://gerrit.wikimedia.org/r/853433

Change 853457 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix string interpolation

https://gerrit.wikimedia.org/r/853457

Change 853434 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@master] DataAccess: Fix string interpolation

https://gerrit.wikimedia.org/r/853434

Change 853466 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/CirrusSearch@master] Fix string interpolation

https://gerrit.wikimedia.org/r/853466

Change 853434 merged by jenkins-bot:

[mediawiki/services/parsoid@master] DataAccess: Fix string interpolation

https://gerrit.wikimedia.org/r/853434

Change 853466 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Fix string interpolation

https://gerrit.wikimedia.org/r/853466

Change 853456 merged by jenkins-bot:

[mediawiki/extensions/LabeledSectionTransclusion@master] LabeledSectionTransclusion: Fix string interpolation

https://gerrit.wikimedia.org/r/853456

Change 853458 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Fix string interpolation

https://gerrit.wikimedia.org/r/853458

Change 853459 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Fix string interpolation

https://gerrit.wikimedia.org/r/853459

Change 853460 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix string interpolation

https://gerrit.wikimedia.org/r/853460

Change 853476 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/DiscussionTools@master] .phan/config.php: Fix string interpolation

https://gerrit.wikimedia.org/r/853476

Change 853477 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/CirrusSearch@master] Fix string interpolation

https://gerrit.wikimedia.org/r/853477

Change 853438 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/CentralNotice@master] AllocationCalculatorTest: Fix string interpolation

https://gerrit.wikimedia.org/r/853438

Change 853477 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Fix string interpolation

https://gerrit.wikimedia.org/r/853477

Change 853476 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] .phan/config.php: Fix string interpolation

https://gerrit.wikimedia.org/r/853476

Change 853438 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] AllocationCalculatorTest: Fix string interpolation

https://gerrit.wikimedia.org/r/853438

Change 853433 merged by jenkins-bot:

[mediawiki/extensions/Math@REL1_39] DeclhTest: Fix string interpolation

https://gerrit.wikimedia.org/r/853433

Change 861464 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a7

https://gerrit.wikimedia.org/r/861464

Change 861464 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a7

https://gerrit.wikimedia.org/r/861464

Change 861472 had a related patch set uploaded (by C. Scott Ananian; author: Arlolra):

[mediawiki/vendor@wmf/1.40.0-wmf.12] Bump parsoid to 0.17.0-a7

https://gerrit.wikimedia.org/r/861472

Change 861472 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.40.0-wmf.12] Bump parsoid to 0.17.0-a7

https://gerrit.wikimedia.org/r/861472

Change 862319 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/libs/RemexHtml@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862319

Change 862345 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] WANObjectCache: Fix string interpolation

https://gerrit.wikimedia.org/r/862345

Change 862319 merged by jenkins-bot:

[mediawiki/libs/RemexHtml@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862319

Change 862375 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/tools/codesniffer@master] New sniff to detect deprecated ${var} in strings

https://gerrit.wikimedia.org/r/862375

Change 862381 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpiceAvatars@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862381

Change 862382 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DynamicPageList@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862382

Change 862383 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Html2Wiki@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862383

Change 862385 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/JsonData@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862385

Change 862386 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Memento@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862386

Change 862387 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PwnedPasswords@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862387

Change 862390 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MathSearch@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862390

Change 862387 merged by jenkins-bot:

[mediawiki/extensions/PwnedPasswords@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862387

Change 862386 merged by jenkins-bot:

[mediawiki/extensions/Memento@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862386

Change 862383 merged by jenkins-bot:

[mediawiki/extensions/Html2Wiki@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862383

Change 862382 merged by jenkins-bot:

[mediawiki/extensions/DynamicPageList@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862382

Change 862345 merged by jenkins-bot:

[mediawiki/core@master] WANObjectCache: Fix string interpolation

https://gerrit.wikimedia.org/r/862345

Change 862381 merged by Umherirrender:

[mediawiki/extensions/BlueSpiceAvatars@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862381

Change 862385 merged by Umherirrender:

[mediawiki/extensions/JsonData@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862385

Change 862390 merged by jenkins-bot:

[mediawiki/extensions/MathSearch@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/862390

composer/spdx-licenses needs to be updated to at least 1.5.7 to include the fix from https://github.com/composer/spdx-licenses/commit/c49d8700039dc3ff27030faeb4e0d12092498863 - mediawiki/core is at 1.5.6 (but is a dev-dep only)

Change 868434 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] composer.json: Updated composer/spdx-licenses from 1.5.6 to 1.5.7

https://gerrit.wikimedia.org/r/868434

Change 868434 merged by jenkins-bot:

[mediawiki/core@master] composer.json: Updated composer/spdx-licenses from 1.5.6 to 1.5.7

https://gerrit.wikimedia.org/r/868434

Change 853417 merged by jenkins-bot:

[mediawiki/libs/XMPReader@master] Validate: Fix string interpolation

https://gerrit.wikimedia.org/r/853417

To get this included into mediawiki/vendor a new release is needed of xmp reader (something newer as 0.9.0, and for REL1_39 something newer as 0.8.5)

Change 853417 merged by jenkins-bot:

[mediawiki/libs/XMPReader@master] Validate: Fix string interpolation

https://gerrit.wikimedia.org/r/853417

To get this included into mediawiki/vendor a new release is needed of xmp reader (something newer as 0.9.0, and for REL1_39 something newer as 0.8.5)

Both tagged.

Change 868528 had a related patch set uploaded (by Reedy; author: Reedy):

[operations/puppet@production] Fix PHP string interpolation

https://gerrit.wikimedia.org/r/868528

Change 868697 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@master] Upgrading wikimedia/xmp-reader (0.9.0 => 0.9.1)

https://gerrit.wikimedia.org/r/868697

Change 868698 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@REL1_39] Upgrading wikimedia/xmp-reader (0.8.5 => 0.8.6)

https://gerrit.wikimedia.org/r/868698

Change 868700 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] Upgrading wikimedia/xmp-reader (0.9.0 => 0.9.1)

https://gerrit.wikimedia.org/r/868700

Change 868701 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] Upgrading wikimedia/xmp-reader (0.8.5 => 0.8.6)

https://gerrit.wikimedia.org/r/868701

Change 868698 merged by Umherirrender:

[mediawiki/vendor@REL1_39] Upgrading wikimedia/xmp-reader (0.8.5 => 0.8.6)

https://gerrit.wikimedia.org/r/868698

Change 868701 merged by jenkins-bot:

[mediawiki/core@REL1_39] Upgrading wikimedia/xmp-reader (0.8.5 => 0.8.6)

https://gerrit.wikimedia.org/r/868701

Change 868697 merged by jenkins-bot:

[mediawiki/vendor@master] Upgrading wikimedia/xmp-reader (0.9.0 => 0.9.1)

https://gerrit.wikimedia.org/r/868697

Change 868700 merged by jenkins-bot:

[mediawiki/core@master] Upgrading wikimedia/xmp-reader (0.9.0 => 0.9.1)

https://gerrit.wikimedia.org/r/868700

Change 876290 had a related patch set uploaded (by Umherirrender; author: Reedy):

[mediawiki/core@REL1_39] composer.json: Updated composer/spdx-licenses from 1.5.6 to 1.5.7

https://gerrit.wikimedia.org/r/876290

Change 876290 merged by jenkins-bot:

[mediawiki/core@REL1_39] composer.json: Updated composer/spdx-licenses from 1.5.6 to 1.5.7

https://gerrit.wikimedia.org/r/876290

Change 884405 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] ClientHtml: Fix use of ${var} string interpolation

https://gerrit.wikimedia.org/r/884405

Change 884405 merged by jenkins-bot:

[mediawiki/core@master] ClientHtml: Fix use of ${var} string interpolation

https://gerrit.wikimedia.org/r/884405

Change 862375 abandoned by Umherirrender:

[mediawiki/tools/codesniffer@master] New sniff to detect deprecated ${var} in strings

Reason:

Possible too limited to get all warnings

https://gerrit.wikimedia.org/r/862375

Change 868528 merged by Giuseppe Lavagetto:

[operations/puppet@production] Fix PHP string interpolation

https://gerrit.wikimedia.org/r/868528

Change 974168 had a related patch set uploaded (by TK-999; author: Reedy):

[mediawiki/extensions/LabeledSectionTransclusion@REL1_39] LabeledSectionTransclusion: Fix string interpolation

https://gerrit.wikimedia.org/r/974168

Change 974168 merged by jenkins-bot:

[mediawiki/extensions/LabeledSectionTransclusion@REL1_39] LabeledSectionTransclusion: Fix string interpolation

https://gerrit.wikimedia.org/r/974168

Change 978060 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/services/parsoid@master] Avoid deprecated variable style

https://gerrit.wikimedia.org/r/978060

Change 978060 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Avoid deprecated variable style

https://gerrit.wikimedia.org/r/978060

Change 982125 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Using ${var} in strings is deprecated, use {$var} instead in PatchJson

https://gerrit.wikimedia.org/r/982125

Change 982125 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Using ${var} in strings is deprecated, use {$var} instead in PatchJson

https://gerrit.wikimedia.org/r/982125

Change 982166 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a8

https://gerrit.wikimedia.org/r/982166

Change 982166 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a8

https://gerrit.wikimedia.org/r/982166

Change 982825 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TimedMediaHandler@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/982825

Change 982832 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@REL1_41] Using ${var} in strings is deprecated, use {$var} instead in PatchJson

https://gerrit.wikimedia.org/r/982832

Change 982833 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TimedMediaHandler@REL1_41] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/982833

Change 982833 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@REL1_41] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/982833

Change 982825 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Using ${var} in strings is deprecated, use {$var} instead

https://gerrit.wikimedia.org/r/982825

Change 982832 merged by Umherirrender:

[mediawiki/extensions/Wikibase@REL1_41] Using ${var} in strings is deprecated, use {$var} instead in PatchJson

https://gerrit.wikimedia.org/r/982832

Change #1019244 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/CirrusSearch@master] Fix string interpolation

https://gerrit.wikimedia.org/r/1019244

Change #1019244 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Fix string interpolation

https://gerrit.wikimedia.org/r/1019244

Change #1019174 had a related patch set uploaded (by Reedy; author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/CirrusSearch@REL1_42] Fix string interpolation

https://gerrit.wikimedia.org/r/1019174

Change #1019174 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@REL1_42] Fix string interpolation

https://gerrit.wikimedia.org/r/1019174