selenium: Default to larger window size
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	kostajh
	Jul 29 2022, 8:20 AM

Description

Some Selenium tests can fail when the viewport is smaller than anticipated (e.g. T314114: Selenium: Close help panel before editing), because an element may be obscured by another one and so is no longer clickable or visible to Selenium. Let's start with a larger window size as the default; individual tests can override this with browser.setWindowSize().

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Revert "selenium: Default to larger window size"	mediawiki/core	master	+2 -5
selenium: Default to larger window size	mediawiki/core	master	+5 -2
wdio-mediawiki: Release 2.2.0	mediawiki/core	master	+5 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T408361 Speed up quibble-with-gated-extensions-selenium-php83 - selenium/webdriverio
Open	None	T408325 Decide screen size for webdriver.io tests in CI
Open	None	T314115 selenium: Default to larger window size

Event Timeline

kostajh created this task.Jul 29 2022, 8:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2022, 8:20 AM

Change 818403 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] selenium: Default to larger window size

https://gerrit.wikimedia.org/r/818403

gerritbot added a project: Patch-For-Review.Jul 29 2022, 8:21 AM

kostajh added a subscriber: Sgs.Jul 29 2022, 8:21 AM

kostajh triaged this task as Low priority.Jul 29 2022, 8:26 AM

kostajh added a project: Growth-Team (Sprint 0 (Growth Team)).

kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 818448 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] wdio-mediawiki: Release 2.2.0

https://gerrit.wikimedia.org/r/818448

zeljkofilipin added projects: User-zeljkofilipin, MediaWiki-Core-Tests.Jul 29 2022, 1:33 PM

zeljkofilipin moved this task from Inbox to QUnit on the MediaWiki-Core-Tests board.

zeljkofilipin moved this task from QUnit to Selenium on the MediaWiki-Core-Tests board.

zeljkofilipin moved this task from Backlog 🪒 to Watching 📺 on the User-zeljkofilipin board.

zeljkofilipin subscribed.

zeljkofilipin changed the task status from Open to In Progress.Aug 25 2022, 10:55 AM

zeljkofilipin claimed this task.

zeljkofilipin moved this task from Inbox to Test engineering on the Quality-and-Test-Engineering-Team board.

zeljkofilipin moved this task from Watching 📺 to Deep work 🌊 on the User-zeljkofilipin board.

Change 818403 merged by jenkins-bot:

[mediawiki/core@master] selenium: Default to larger window size

https://gerrit.wikimedia.org/r/818403

Change 818448 merged by jenkins-bot:

[mediawiki/core@master] wdio-mediawiki: Release 2.2.0

https://gerrit.wikimedia.org/r/818448

Maintenance_bot removed a project: Patch-For-Review.Aug 30 2022, 2:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.28; 2022-09-05).Aug 30 2022, 3:00 PM

wdio-mediawiki@2.2.0 is published.

zeljkofilipin reopened this task as Open.Oct 25 2022, 12:48 PM

Change 849073 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] Revert "selenium: Default to larger window size"

https://gerrit.wikimedia.org/r/849073

gerritbot added a project: Patch-For-Review.Oct 25 2022, 12:50 PM

818403 broke video recording in CI. I've reverted it with 849073. See T317879: ffmpeg stderr Capture area 1920x1080 at position 0.0 outside the screen size 1280x1024. I'm not opposed to changing the screen size, but looks like CI has to be updated to support larger screen size too.

zeljkofilipin moved this task from Deep work 🌊 to Watching 📺 on the User-zeljkofilipin board.Oct 25 2022, 12:56 PM

Change 849073 merged by jenkins-bot:

[mediawiki/core@master] Revert "selenium: Default to larger window size"

https://gerrit.wikimedia.org/r/849073

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 25 2022, 2:00 PM

kostajh moved this task from Code Review to Blocked / Needs work on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 28 2022, 8:33 AM

In T314115#8341396, @zeljkofilipin wrote:

818403 broke video recording in CI. I've reverted it with 849073. See T317879: ffmpeg stderr Capture area 1920x1080 at position 0.0 outside the screen size 1280x1024. I'm not opposed to changing the screen size, but looks like CI has to be updated to support larger screen size too.

@zeljkofilipin is this something that your team could work on? I don't think the Growth team can pursue it, as we already have a workaround in T314114: Selenium: Close help panel before editing.

kostajh moved this task from Inbox to Triaged on the Growth-Team board.Jan 16 2023, 12:59 PM

@kostajh sure, but we're currently busy with T324685: Upgrade WebdriverIO to v8 in all repositories. Is this urgent?

zeljkofilipin moved this task from Watching 📺 to Backlog 🪒 on the User-zeljkofilipin board.Feb 3 2023, 1:56 PM

In T314115#8585308, @zeljkofilipin wrote:

@kostajh sure, but we're currently busy with T324685: Upgrade WebdriverIO to v8 in all repositories. Is this urgent?

No, it is not urgent.

Maintenance_bot removed a project: Patch-For-Review.Feb 3 2023, 2:30 PM

@kostajh feel free to unassign the task from yourself, I can work on it, but I'm not sure when I'll have the time.

kostajh removed kostajh as the assignee of this task.Feb 3 2023, 4:20 PM

zeljkofilipin raised the priority of this task from Low to Needs Triage.Feb 6 2023, 12:59 PM

zeljkofilipin added a parent task: T210726: Selenium framework maintenance.

zeljkofilipin mentioned this in T210726: Selenium framework maintenance.

• TAdeleye_WMF edited projects, added Quality-and-Test-Engineering-Team (Test engineering); removed Quality-and-Test-Engineering-Team.Feb 28 2023, 7:25 PM

The latest version of wdio-mediawiki is 2.2.0, but as noted above, it breaks video recording in CI. I think it's fine if this task is not fixed immediately, but shouldn't we publish a new version including the revert, so that people don't try to upgrade just to later realize that the new shiny version doesn't work? (This is definitely not what happened to yours truly)

kostajh mentioned this in T337137: Some GrowthExperiments Selenium tests failing, because the browser window is too small (it's not in fullscreen mode).May 20 2023, 6:11 PM

@Daimona I agree, we should release new version of wdio-mediawiki. It's on my todo list, but I'm not sure when I'll get to it.

WMDE-Fisch mentioned this in T342222: Release a new version of wdio-mediawiki.Jul 19 2023, 11:39 AM

zeljkofilipin removed a project: User-zeljkofilipin.Jan 13 2025, 11:19 AM

zeljkofilipin added a project: Testing Support.Mar 12 2025, 11:27 AM

zeljkofilipin removed a project: Browser-Tests.Mar 20 2025, 6:00 PM

zeljkofilipin removed a project: Quality-and-Test-Engineering-Team (Test engineering).Mar 20 2025, 6:05 PM

zeljkofilipin removed a project: MediaWiki-Core-Tests.Mar 24 2025, 6:31 PM

Daimona mentioned this in T390097: Selenium video recordings mix together unrelated parallel tests.Mar 27 2025, 2:27 PM

Daimona mentioned this in T344754: Browser tests video capture is shared between tests.Mar 27 2025, 2:42 PM

zeljkofilipin edited projects, added Test Platform; removed Testing Support.Aug 13 2025, 1:54 PM

zeljkofilipin removed a parent task: T210726: Selenium framework maintenance.