Page MenuHomePhabricator

Add primary key and drop unique index on translate_messageindex on wmf wikis
Closed, ResolvedPublic

Description

Apply T312258 to wmf wikis

  1. ALTERs to run: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/817872/2/sql/mysql/patch-translate_messageindex-unique-to-pk.sql
  2. Where to run those changes: Active according to the config: advisorswiki, amwikimedia, bewikimedia, betawikiversity, brwikimedia, bdwikimedia, cawikimedia, collabwiki, commonswiki, testcommonswiki, foundationwiki, frwiktionary, gewikimedia, grwikimedia, hiwikimedia, idwikimedia, incubatorwiki, legalteamwiki, maiwikimedia, mediawikiwiki, metawiki, nowikimedia, otrs_wikiwiki, outreachwiki, plwikimedia, ruwikimedia, punjabiwikimedia, sourceswiki, specieswiki, sewikimedia, testwiki, uawikimedia, wbwikimedia, wikidata, wikimania2012wiki, wikimania2013wiki, wikimania2014wiki, wikimania2015wiki, wikimania2016wiki, wikimania2017wiki, wikimania2018wiki, wikimaniawiki
  3. When to run those changes: any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: beta already running with the new schema
  6. if the data should be made available on the labs replicas and/or dumps: no change of the existing rules

Due to a bug in the schema change generator (T314138) the DROP + ALTER should be rewritten to be atomic

Progress

Event Timeline

Marostegui moved this task from Triage to In progress on the DBA board.

Per section wikis:
s3:

advisorswiki
amwikimedia
bewikimedia
betawikiversity
brwikimedia
bdwikimedia
cawikimedia
collabwiki
foundationwiki
gewikimedia
grwikimedia
hiwikimedia
idwikimedia
incubatorwiki
legalteamwiki
maiwikimedia
mediawikiwiki
nowikimedia
otrs_wikiwiki
outreachwiki
plwikimedia
ruwikimedia
punjabiwikimedia
sourceswiki
specieswiki
sewikimedia
testwiki
testwikidatawiki
uawikimedia
wbwikimedia
testwikidatawiki
wikimania2012wiki
wikimania2013wiki
wikimania2014wiki
wikimania2015wiki
wikimania2016wiki
wikimania2017wiki
wikimania2018wiki
wikimaniawiki

s4:

commonswiki
testcommonswiki

s7:

frwiktionary
metawiki

s8:

wikidatawiki

in s3 the table is only present at:

bdwikimedia
betawikiversity
bewikimedia
brwikimedia
collabwiki
foundationwiki
incubatorwiki
mediawikiwiki
legalteamwiki
nowikimedia
otrs_wikiwiki
outreachwiki
plwikimedia
ruwikimedia
sewikimedia
sourceswiki
specieswiki
testwiki
testwikidatawiki
uawikimedia
wikimania2012wiki
wikimania2014wiki
wikimania2013wiki
wikimania2015wiki
wikimania2017wiki
wikimania2016wiki
maiwikimedia
amwikimedia
wikimania2018wiki
wbwikimedia
cawikimedia
advisorswiki
hiwikimedia
idwikimedia
punjabiwikimedia
grwikimedia
gewikimedia
wikimaniawiki

Done in s4 with replication

Deploying in s3 master with replication and a sleep

Marostegui updated the task description. (Show Details)

s7 done with replication.
All completed.

This broke replication on db1174 for metawiki.
Probably this host needs recloning (it was the only one that didn't have that UNIQUE key).