Page MenuHomePhabricator
Create Task
Maniphest T314155

Translate "Connection type" data returned from MaxMind
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

IPInfo displays data from MaxMind about an IP address. Currently "Connection type" data is displayed as returned from MaxMind. We should instead display a message translation, depending on the type returned.

Possible types are:

  • Dialup
  • Cable/DSL
  • Corporate
  • Cellular

Reference: https://github.com/maxmind/GeoIP2-php/blob/7598c36acb96b18c2f30da4d03a4c340bc8fac92/src/Model/ConnectionType.php#L12
An example of where it was useful to clarify: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/IPInfo/+/refs/heads/master/i18n/qqq.json#29

AC

Details

SubjectRepoBranchLines +/-
Translate "Connection type" data returned from MaxMindmediawiki/extensions/IPInfomaster+30 -1
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Jul 29 2022, 3:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2022, 3:11 PM
Tchanders updated the task description. (Show Details)Jul 29 2022, 3:12 PM
Tchanders mentioned this in T314157: Translate "User type" data returned from MaxMind.Aug 1 2022, 5:19 PM
Tchanders updated the task description. (Show Details)Aug 1 2022, 5:23 PM
Tchanders set the point value for this task to 2.
Tchanders moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
STran updated the task description. (Show Details)Aug 1 2022, 11:02 PM
STran updated the task description. (Show Details)
• Prtksxna updated the task description. (Show Details)Aug 2 2022, 4:21 AM
• Prtksxna updated the task description. (Show Details)
ARamirez_WMF moved this task from Cards ready for development to AHaT Sprint 13: The Magikarp Hat on the Anti-Harassment board.Aug 2 2022, 5:15 PM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 13: The Magikarp Hat); removed Anti-Harassment.
• Prtksxna moved this task from Backlog to In Progress on the IP Info board.Aug 8 2022, 4:05 AM
• TThoabala claimed this task.Aug 10 2022, 4:31 PM
• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 13: The Magikarp Hat) board.Aug 12 2022, 4:36 AM
gerritbot added a comment.Aug 12 2022, 5:10 AM

Change 822497 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] Translate "Connection type" data returned from MaxMind

https://gerrit.wikimedia.org/r/822497

gerritbot added a project: Patch-For-Review.Aug 12 2022, 5:10 AM
• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 13: The Magikarp Hat) board.Aug 12 2022, 5:13 AM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 14: The Umbrella Hat); removed Anti-Harassment (AHaT Sprint 13: The Magikarp Hat).Aug 16 2022, 4:20 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 14: The Umbrella Hat) board.
gerritbot added a comment.Aug 16 2022, 6:38 PM

Change 822497 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Translate "Connection type" data returned from MaxMind

https://gerrit.wikimedia.org/r/822497

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 16 2022, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 16 2022, 7:30 PM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 14: The Umbrella Hat) board.Aug 17 2022, 1:43 PM
dom_walden moved this task from QA/Testing 🐞 to Done Q1 2022-2023 on the Anti-Harassment (AHaT Sprint 14: The Umbrella Hat) board.Aug 19 2022, 1:54 PM
dom_walden subscribed.

I can see translations (en, fr, de) for various values of the "Connection method" (Corporate, Cellular) in the Infobox.

We still see Not available when there is no data.

Test environment: local docker IP Info 0.0.0 (669fac4) 06:29, 19 August 2022.

• Prtksxna added a comment.Sep 2 2022, 4:08 AM
In T314155#8169102, @dom_walden wrote:

We still see Not available when there is no data.

Confirming that we are continuing to see Not available in the chosen language (as we already do).

Niharika closed this task as Resolved.Sep 2 2022, 8:48 PM
• Prtksxna moved this task from In Progress to Closed on the IP Info board.Sep 6 2022, 8:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL