str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Jul 30 2022, 3:13 AM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Reedy

RussRogovetz

Description

27) ApiMainTest::testApi
str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated

/var/www/wiki/mediawiki/extensions/SiteMatrix/includes/SiteMatrix.php:298
/var/www/wiki/mediawiki/extensions/SiteMatrix/includes/SiteMatrix.php:320
/var/www/wiki/mediawiki/extensions/SiteMatrix/includes/Hooks.php:25
/var/www/wiki/mediawiki/core/includes/HookContainer/HookContainer.php:338
/var/www/wiki/mediawiki/core/includes/HookContainer/HookContainer.php:137
/var/www/wiki/mediawiki/core/includes/api/ApiHookRunner.php:219
/var/www/wiki/mediawiki/core/includes/api/ApiQuerySiteinfo.php:387
/var/www/wiki/mediawiki/core/includes/api/ApiQuerySiteinfo.php:145
/var/www/wiki/mediawiki/core/includes/api/ApiQuery.php:666
/var/www/wiki/mediawiki/core/includes/api/ApiMain.php:1901
/var/www/wiki/mediawiki/core/includes/api/ApiMain.php:844
/var/www/wiki/mediawiki/core/tests/phpunit/includes/api/ApiMainTest.php:46
/var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiIntegrationTestCase.php:498
/var/www/wiki/mediawiki/core/tests/phpunit/phpunit.php:101
/var/www/wiki/mediawiki/core/tests/phpunit/phpunit.php:153

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Check the return value from SiteConfiguration::siteFromDB()	Reedy	mediawiki/extensions/SiteMatrix	REL1_39	+15 -1
	Check the return value from SiteConfiguration::siteFromDB()	Tim Starling	mediawiki/extensions/SiteMatrix	master	+15 -1

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Jdforrester-WMF	T319065 All Wikimedia production extensions and skins must support PHP 8.1
Resolved	tstarling	T314212 str_replace(): Passing null to parameter #3 ($subject) of type array\|string is deprecated
		· · ·

Event Timeline

Reedy created this task.Jul 30 2022, 3:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2022, 3:13 AM

Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.Jul 30 2022, 3:15 AM

It looks like str_replace( '-', '_', $minor ) is done in numerous places in the code... As output from $wgConf->siteFromDB().

Which is documented to return null!

	/**
	 * Work out the site and language name from a database name
	 * @param string $wiki Wiki ID
	 *
	 * @return array [ string|null $site, string|null $languageCode ]
	 */
	public function siteFromDB( $wiki ) {

RussRogovetz subscribed.Aug 16 2022, 3:25 PM

Jdforrester-WMF added a parent task: T319065: All Wikimedia production extensions and skins must support PHP 8.1.Sep 30 2022, 6:13 PM

Change 850684 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/SiteMatrix@master] Check the return value from SiteConfiguration::siteFromDB()

https://gerrit.wikimedia.org/r/850684

gerritbot added a project: Patch-For-Review.Oct 31 2022, 4:56 AM

Change 850684 merged by jenkins-bot:

[mediawiki/extensions/SiteMatrix@master] Check the return value from SiteConfiguration::siteFromDB()

https://gerrit.wikimedia.org/r/850684

tstarling mentioned this in rESMX0f49a23e5968: Check the return value from SiteConfiguration::siteFromDB().Nov 1 2022, 1:01 AM

Maintenance_bot removed a project: Patch-For-Review.Nov 1 2022, 1:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 1 2022, 2:00 AM

Jdforrester-WMF closed this task as Resolved.Nov 1 2022, 8:38 PM

Jdforrester-WMF assigned this task to tstarling.

Change #1148462 had a related patch set uploaded (by Reedy; author: Tim Starling):

[mediawiki/extensions/SiteMatrix@REL1_39] Check the return value from SiteConfiguration::siteFromDB()

https://gerrit.wikimedia.org/r/1148462

Change #1148462 merged by jenkins-bot: