27) ApiMainTest::testApi str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated /var/www/wiki/mediawiki/extensions/SiteMatrix/includes/SiteMatrix.php:298 /var/www/wiki/mediawiki/extensions/SiteMatrix/includes/SiteMatrix.php:320 /var/www/wiki/mediawiki/extensions/SiteMatrix/includes/Hooks.php:25 /var/www/wiki/mediawiki/core/includes/HookContainer/HookContainer.php:338 /var/www/wiki/mediawiki/core/includes/HookContainer/HookContainer.php:137 /var/www/wiki/mediawiki/core/includes/api/ApiHookRunner.php:219 /var/www/wiki/mediawiki/core/includes/api/ApiQuerySiteinfo.php:387 /var/www/wiki/mediawiki/core/includes/api/ApiQuerySiteinfo.php:145 /var/www/wiki/mediawiki/core/includes/api/ApiQuery.php:666 /var/www/wiki/mediawiki/core/includes/api/ApiMain.php:1901 /var/www/wiki/mediawiki/core/includes/api/ApiMain.php:844 /var/www/wiki/mediawiki/core/tests/phpunit/includes/api/ApiMainTest.php:46 /var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiIntegrationTestCase.php:498 /var/www/wiki/mediawiki/core/tests/phpunit/phpunit.php:101 /var/www/wiki/mediawiki/core/tests/phpunit/phpunit.php:153
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Check the return value from SiteConfiguration::siteFromDB() | mediawiki/extensions/SiteMatrix | master | +15 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Stalled | None | T255792 Quibble runs core:unit tests twice! | |||
| Open | None | T328919 Upgrade to PHPUnit 10 | |||
| Open | None | T338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+ | |||
| Open | None | T328921 Drop PHP 7.4 support from MediaWiki | |||
| Stalled | None | T334726 Use return type `never` in Wikibase | |||
| Open | None | T328922 Drop PHP 8.0 support from MediaWiki | |||
| Stalled | None | T319055 Upgrade to psr/container 2.x | |||
| Stalled | Krinkle | T319432 Migrate WMF production from PHP 7.4 to PHP 8.1 | |||
| Resolved | Jdforrester-WMF | T316078 Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries) | |||
| Resolved | Jdforrester-WMF | T319065 All Wikimedia production extensions and skins must support PHP 8.1 | |||
| Resolved | tstarling | T314212 str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated |
Event Timeline
Comment Actions
It looks like str_replace( '-', '_', $minor ) is done in numerous places in the code... As output from $wgConf->siteFromDB().
Which is documented to return null!
/** * Work out the site and language name from a database name * @param string $wiki Wiki ID * * @return array [ string|null $site, string|null $languageCode ] */ public function siteFromDB( $wiki ) {
Comment Actions
Change 850684 had a related patch set uploaded (by Tim Starling; author: Tim Starling):
[mediawiki/extensions/SiteMatrix@master] Check the return value from SiteConfiguration::siteFromDB()
Comment Actions
Change 850684 merged by jenkins-bot:
[mediawiki/extensions/SiteMatrix@master] Check the return value from SiteConfiguration::siteFromDB()