Page MenuHomePhabricator

Checkuserblock form is broken when paging links are shown on 'Get users'
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Load the 'Get users' result with an IP
  • Try to use the block form
  • The form does not submit

Software version (skip for WMF-hosted wikis like Wikipedia):
Checkuser on the master branch

Other information (browser name/version, screenshots, etc.):
Latest Firefox

This fails because the paging links which are added on the get users screen use a form element to ensure that the data is sent via POST. The HTML spec says that forms cannot be nested, so at least in Firefox the form element is ignored. The quickest fix for this is to remove the paging links at the bottom, but an alternative is for non-IE browsers use the HTML form attribute on the checkboxes so that the bottom paging links can be shown on non-IE browsers. IE browsers do not support this attribute so some browser detection would be needed.

Event Timeline

Dreamy_Jazz renamed this task from Checkuserblock form is broken to Checkuserblock form is broken when paging links are shown on 'Get users'.Jul 30 2022, 11:19 AM
Dreamy_Jazz triaged this task as High priority.
Dreamy_Jazz moved this task from General / Unsorted to CheckUser on the CheckUser board.

Change 818530 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove the bottom paging links for 'Get users' as forms cannot be nested

https://gerrit.wikimedia.org/r/818530

Change 818530 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove the bottom paging links for 'Get users' as forms cannot be nested

https://gerrit.wikimedia.org/r/818530

Merged and fixed. Closing. Will look into restoring these bottom paging links in a future patch.