Maniphest T314237

Check front end code for obscure Benjamin array bugs
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	DMartin-WMF
	Jul 31 2022, 5:29 AM

Tags

Referenced Files

None

Subscribers

Description

This patch fixed a non-obvious Benjamin array bug:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/818597

We should probably look around the front end JavaScript & Vue code for any similar cases that haven't yet been addressed.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix ZFunctionTesterReport to handle Benjamin arrays	mediawiki/extensions/WikiLambda	master	+10 -4

Customize query in gerrit

Event Timeline

DMartin-WMF created this task.Jul 31 2022, 5:29 AM

DMartin-WMF added a subscriber: gengh.Jul 31 2022, 5:32 AM

Change 818597 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Fix computed properties to handle Benjamin arrays

https://gerrit.wikimedia.org/r/818597

gerritbot added a project: Patch-For-Review.Jul 31 2022, 5:45 AM

Aklapper added a project: Abstract Wikipedia Fix-It tasks.Aug 1 2022, 9:03 AM

Aklapper removed a subscriber: Abstract Wikipedia Fix-It tasks.

DVrandecic moved this task from To Triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Aug 1 2022, 6:38 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

Change 818597 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix ZFunctionTesterReport to handle Benjamin arrays

https://gerrit.wikimedia.org/r/818597

Maintenance_bot removed a project: Patch-For-Review.Aug 3 2022, 11:30 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 3 2022, 12:00 PM

Jdforrester-WMF moved this task from Incoming to Blocking launch on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:29 PM

Jdforrester-WMF triaged this task as High priority.Mar 24 2023, 1:00 AM

Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Jun 14 2023, 2:03 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).

• Mcastro moved this task from To triage: Nice-to-haves to Verify in production on the Abstract Wikipedia team board.Jan 18 2024, 5:51 PM

Jdforrester-WMF closed this task as Resolved.Jan 18 2024, 6:17 PM