Page MenuHomePhabricator
Create Task
Maniphest T314294

Deploy Phonos to beta cluster
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment#Deploy_to_Beta_Cluster

  • Add the new extension submodule to the git mediawiki/extensions repo if it's not already in it. See example. This will result in the code being deployed (unused) to the Beta Cluster.
  • Move your extension's CI config to the "Wikimedia production" section, add the "in-wikimedia-production" job template, and make sure it has and passes all the expected jobs for production code. See example.
  • Add your extension to the json make-wmf-branch release tool at least two weeks prior to your target date for enabling on the Beta Cluster. It will add the extension as a submodule of mediawiki/core when the weekly deploy branch is cut, and the code will be deployed (unused) to production (see explanation in the next step).
  • Add your extension to extension-list. See example. This requires that the code be present on every branch running in production, since extension-list is used to build the CDB database for i18n files in both Beta and production.
  • Add your extension config variable to InitialiseSettings.php and set it to be default false. See example.
  • Add your extension config variable (same as in previous step) to InitialiseSettings-labs.php and set it to be true on Beta Cluster wikis you want it to be on. You may want to turn it off for loginwiki (which doesn't have most extensions). See example.
  • Load your extension in CommonSettings-labs.php. See https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/455601/.
  • Per T316011: Rollout plan for Phonos, enable on Beta en.wiki, en.wikt and en-rtl.wiki

Details

SubjectRepoBranchLines +/-
InitialiseSettings-labs: Enable Phonos on en_rtlwiki, enwiktionaryoperations/mediawiki-configmaster+2 -0
CommonSettings-labs: Set config to production-esque valuesoperations/mediawiki-configmaster+2 -3
CommonSettings-labs: Load Phonos extensionoperations/mediawiki-configmaster+8 -0
InitialiseSettings-labs: Enable Phonos on beta enwikioperations/mediawiki-configmaster+6 -0
InitialiseSettings: Add wmgUsePhonos (default => false)operations/mediawiki-configmaster+5 -0
extension-list: Add Phonosoperations/mediawiki-configmaster+1 -0
settings.yaml: Add Phonos to wmf_core sectionmediawiki/tools/releasemaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Aug 8 2022, 2:23 PM

Change 821249 had a related patch set uploaded (by Samtar; author: Samtar):

[operations/mediawiki-config@master] extension-list: Add Phonos

https://gerrit.wikimedia.org/r/821249

gerritbot added a project: Patch-For-Review.Aug 8 2022, 2:23 PM
gerritbot added a comment.Aug 12 2022, 4:01 PM

Change 822656 had a related patch set uploaded (by Samtar; author: Samtar):

[operations/mediawiki-config@master] InitialiseSettings: Add wmgUsePhonos (default => false)

https://gerrit.wikimedia.org/r/822656

TheresNoTime changed the task status from Open to Stalled.EditedAug 15 2022, 9:59 PM

Waiting for at least two mw trains per comments at https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/821249

T314186: 1.39.0-wmf.25 deployment blockers dependent, should be set to move this patch forwards on Friday 19th

TheresNoTime changed the task status from Stalled to Open.Aug 17 2022, 11:02 AM

Scheduled 821249 for today UTC late

gerritbot added a comment.Aug 17 2022, 8:25 PM

Change 821249 merged by jenkins-bot:

[operations/mediawiki-config@master] extension-list: Add Phonos

https://gerrit.wikimedia.org/r/821249

Stashbot added a comment.Aug 17 2022, 8:29 PM

Mentioned in SAL (#wikimedia-operations) [2022-08-17T20:29:58Z] <samtar@deploy1002> Synchronized wmf-config/extension-list: Config: [[gerrit:821249|extension-list: Add Phonos (T314294)]] (duration: 03m 17s)

gerritbot added a comment.Aug 17 2022, 8:31 PM

Change 822656 merged by jenkins-bot:

[operations/mediawiki-config@master] InitialiseSettings: Add wmgUsePhonos (default => false)

https://gerrit.wikimedia.org/r/822656

Stashbot added a comment.Aug 17 2022, 8:36 PM

Mentioned in SAL (#wikimedia-operations) [2022-08-17T20:36:00Z] <samtar@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:822656|InitialiseSettings: Add wmgUsePhonos (default => false) (T314294)]] (duration: 03m 29s)

TheresNoTime updated the task description. (Show Details)Aug 17 2022, 8:36 PM
gerritbot added a comment.Aug 17 2022, 8:52 PM

Change 824291 had a related patch set uploaded (by Samtar; author: Samtar):

[operations/mediawiki-config@master] InitialiseSettings-labs: Enable Phonos on beta enwiki

https://gerrit.wikimedia.org/r/824291

TheresNoTime added a comment.Aug 17 2022, 9:01 PM

Going to set Beta to use larynx for initial testing

gerritbot added a comment.Aug 17 2022, 9:04 PM

Change 824294 had a related patch set uploaded (by Samtar; author: Samtar):

[operations/mediawiki-config@master] CommonSettings: Load Phonos extension

https://gerrit.wikimedia.org/r/824294

TheresNoTime added a comment.EditedAug 17 2022, 9:19 PM

https://gerrit.wikimedia.org/r/824291 is scheduled for tomorrow's UTC afternoon backport window — this will set https://en.wikipedia.beta.wmflabs.org as the only beta cluster wiki to have Phonos enabled. It will not enable the extension.

// T314294
'wmgUsePhonos' => [
    'default' => false,
    'enwiki' => true,
],

Once this is deployed, the remaining patch will enable Phonos — we should discuss and agree on if Phonos is stable enough to be enabled.

I've initially added the following configuration:

if ( $wmgUsePhonos ) {
    wfLoadExtension( 'Phonos' );
    // T314294#8163339 — Initial testing configuration
    $wgPhonosEngine = 'larynx';
    $wgPhonosApiEndpointLarynx = 'https://larynx-tts.wmcloud.org/api/tts';
}
TheresNoTime changed the task status from Open to Stalled.Aug 18 2022, 11:43 AM

Pending a decision on enable now vs enable after T315482: Generate HTML server side for IPA audio button (and related) — either option is is stable enough for deployment imho

gerritbot added a comment.Aug 18 2022, 1:09 PM

Change 824291 merged by jenkins-bot:

[operations/mediawiki-config@master] InitialiseSettings-labs: Enable Phonos on beta enwiki

https://gerrit.wikimedia.org/r/824291

Stashbot added a comment.Aug 18 2022, 1:13 PM

Mentioned in SAL (#wikimedia-operations) [2022-08-18T13:13:33Z] <samtar@deploy1002> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:824291|InitialiseSettings-labs: Enable Phonos on beta enwiki (T314294)]] (duration: 03m 30s)

TheresNoTime updated the task description. (Show Details)Aug 18 2022, 3:23 PM
TheresNoTime mentioned this in T314296: Security review of Phonos Extension.
TheresNoTime added a subscriber: • NRodriguez.Aug 19 2022, 12:41 AM

Now stalled on T314296#8167794 — we must not merge mediawiki-config/+/824294 until manager-level oversight and acceptance of the deployment risk.

TheresNoTime mentioned this in T316011: Rollout plan for Phonos.Aug 23 2022, 1:59 PM
TheresNoTime updated the task description. (Show Details)Aug 23 2022, 2:51 PM
TheresNoTime changed the status of subtask T315491: Add $wgPhonosApiKeyGoogle to PrivateSettings from Open to Stalled.
TheresNoTime mentioned this in T315491: Add $wgPhonosApiKeyGoogle to PrivateSettings.
TheresNoTime mentioned this in T316020: Accept Phonos Beta cluster deployment risk.Aug 23 2022, 2:57 PM
• NRodriguez moved this task from Backlog to 🌟Top Priority on the MediaWiki-extensions-Phonos board.Aug 30 2022, 2:06 PM
TheresNoTime changed the task status from Stalled to Open.Sep 5 2022, 8:49 AM

Unstalled in T316020#8206955

TheresNoTime added a comment.Sep 6 2022, 7:21 AM

455601 scheduled for today

TheresNoTime updated the task description. (Show Details)Sep 6 2022, 8:46 AM
gerritbot added a comment.Sep 6 2022, 1:07 PM

Change 824294 merged by jenkins-bot:

[operations/mediawiki-config@master] CommonSettings-labs: Load Phonos extension

https://gerrit.wikimedia.org/r/824294

Stashbot added a comment.Sep 6 2022, 1:19 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-06T13:19:41Z] <samtar@deploy1002> Synchronized wmf-config/CommonSettings-labs.php: Config: [[gerrit:824294|CommonSettings-labs: Load Phonos extension (T314294)]] (duration: 04m 05s)

Maintenance_bot removed a project: Patch-For-Review.Sep 6 2022, 1:30 PM
TheresNoTime changed the status of subtask T315491: Add $wgPhonosApiKeyGoogle to PrivateSettings from Stalled to Open.Sep 7 2022, 8:49 AM
gerritbot added a comment.Sep 7 2022, 8:54 AM

Change 830567 had a related patch set uploaded (by Samtar; author: Samtar):

[operations/mediawiki-config@master] CommonSettings-labs: Set config to production-esque values

https://gerrit.wikimedia.org/r/830567

gerritbot added a project: Patch-For-Review.Sep 7 2022, 8:54 AM
TheresNoTime updated the task description. (Show Details)Sep 7 2022, 10:03 AM
gerritbot added a comment.Sep 7 2022, 1:48 PM

Change 830567 merged by jenkins-bot:

[operations/mediawiki-config@master] CommonSettings-labs: Set config to production-esque values

https://gerrit.wikimedia.org/r/830567

Stashbot added a comment.Sep 7 2022, 1:55 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-07T13:55:56Z] <samtar@deploy1002> Synchronized wmf-config/CommonSettings-labs.php: Config: [[gerrit:830567|CommonSettings-labs: Set config to production-esque values (T314294)]] (duration: 03m 47s)

Maintenance_bot removed a project: Patch-For-Review.Sep 7 2022, 2:30 PM
TheresNoTime changed the task status from Open to Stalled.Sep 8 2022, 5:32 PM
TheresNoTime edited projects, added Community-Tech (CommTech-Sprint-32); removed Community-Tech.
TheresNoTime moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-32) board.

Moving to QA but stalling due to T317195: Failed to create storage directory on Beta Cluster — once that is resolved, this should be QAable

TheresNoTime added a subtask: T317195: Failed to create storage directory on Beta Cluster.Sep 9 2022, 1:39 PM
TheresNoTime added a subtask: T317128: Failed to convert audio to MP3: /bin/bash: /usr/bin/lame: No such file or directory on Beta Cluster.
TheresNoTime closed subtask T317195: Failed to create storage directory on Beta Cluster as Resolved.Sep 9 2022, 2:42 PM
TheresNoTime changed the status of subtask T315491: Add $wgPhonosApiKeyGoogle to PrivateSettings from Open to Stalled.Sep 9 2022, 4:02 PM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-33); removed Community-Tech (CommTech-Sprint-32).Sep 12 2022, 3:00 PM
• JMcLeod_WMF moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-33) board.Sep 12 2022, 3:01 PM
TheresNoTime updated the task description. (Show Details)Sep 20 2022, 10:16 AM
TheresNoTime moved this task from QA 🐛 to Needs Attention 👀 on the Community-Tech (CommTech-Sprint-33) board.
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-34); removed Community-Tech (CommTech-Sprint-33).Sep 26 2022, 8:27 PM
• JMcLeod_WMF moved this task from Ready 🎬 to Needs Attention 👀 on the Community-Tech (CommTech-Sprint-34) board.Sep 26 2022, 8:37 PM
TheresNoTime added a comment.Oct 5 2022, 7:43 AM

We remain stalled on T317195: Failed to create storage directory on Beta Cluster (which became T317417: Phonos links to an unauthorized URL)

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-35); removed Community-Tech (CommTech-Sprint-34).Oct 11 2022, 10:27 AM
• JMcLeod_WMF moved this task from Ready 🎬 to Needs Attention 👀 on the Community-Tech (CommTech-Sprint-35) board.Oct 11 2022, 10:32 AM
TheresNoTime updated the task description. (Show Details)Oct 11 2022, 1:29 PM
TheresNoTime closed this task as Resolved.Oct 11 2022, 2:02 PM
TheresNoTime reopened this task as Open.Oct 11 2022, 2:18 PM
TheresNoTime moved this task from Needs Attention 👀 to QA 🐛 on the Community-Tech (CommTech-Sprint-35) board.

Will put this in QA, I suppose the acceptance criteria is "Phonos works on the Beta Cluster"

TheresNoTime mentioned this in T317417: Phonos links to an unauthorized URL.Oct 11 2022, 3:06 PM
gerritbot added a comment.Oct 11 2022, 3:23 PM

Change 841547 had a related patch set uploaded (by Samtar; author: Samtar):

[operations/mediawiki-config@master] InitialiseSettings-labs: Enable Phonos on en_rtlwiki, enwiktionary

https://gerrit.wikimedia.org/r/841547

gerritbot added a project: Patch-For-Review.Oct 11 2022, 3:23 PM
TheresNoTime updated the task description. (Show Details)Oct 11 2022, 3:24 PM
TheresNoTime moved this task from QA 🐛 to In Development 💻 on the Community-Tech (CommTech-Sprint-35) board.
gerritbot added a comment.Oct 11 2022, 3:30 PM

Change 841547 merged by jenkins-bot:

[operations/mediawiki-config@master] InitialiseSettings-labs: Enable Phonos on en_rtlwiki, enwiktionary

https://gerrit.wikimedia.org/r/841547

Stashbot added a comment.Oct 11 2022, 3:31 PM

Mentioned in SAL (#wikimedia-operations) [2022-10-11T15:30:59Z] <TheresNoTime> deployed beta cluster only change, [[gerrit:841547]], for T314294

TheresNoTime updated the task description. (Show Details)Oct 11 2022, 3:31 PM
TheresNoTime moved this task from In Development 💻 to QA 🐛 on the Community-Tech (CommTech-Sprint-35) board.

Now ready for QA — Phonos should be enabled on:

GMikesell-WMF subscribed.Oct 11 2022, 8:29 PM
In T314294#8308228, @TheresNoTime wrote:

Now ready for QA — Phonos should be enabled on:

@TheresNoTime Phonos passed on all 3 links but we did want to ask you one more thing before moving it to production sign-off. We noticed that on the first link (https://en.wikipedia.beta.wmflabs.org/wiki/Phonos), a few of the phonos words that are highlighted in the screenshot say the text word instead of the actual word. We are not sure if this is an issue or not but please let us know if this is ok to move it to production sign-off. Thanks!

T314294_PhonosToBeta.png (945×3 px, 342 KB)

Links tested and successfully passed

TheresNoTime moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-35) board.Oct 11 2022, 9:03 PM
In T314294#8309598, @GMikesell-WMF wrote:
In T314294#8308228, @TheresNoTime wrote:

Now ready for QA — Phonos should be enabled on:

@TheresNoTime Phonos passed on all 3 links but we did want to ask you one more thing before moving it to production sign-off. We noticed that on the first link (https://en.wikipedia.beta.wmflabs.org/wiki/Phonos), a few of the phonos words that are highlighted in the screenshot say the text word instead of the actual word. We are not sure if this is an issue or not but please let us know if this is ok to move it to production sign-off. Thanks!

T314294_PhonosToBeta.png (945×3 px, 342 KB)

Links tested and successfully passed

Thanks for letting me know — I'm going to consider that its own issue (which is tracked elsewhere I believe), and given that Phonos is "working" on the Beta Cluster I'll move this to sign-off :)

TheDJ subscribed.EditedOct 12 2022, 8:25 AM

Nice work. Someone might want to check if different text sizes can be handled a bit better perhaps ? https://en.wikipedia.beta.wmflabs.org/wiki/Phonos#Text_sizes

{F35564149}

TheresNoTime mentioned this in T320820: Phonos speaker icon placement moves on increased/reduced font size.Oct 14 2022, 3:22 PM
In T314294#8310344, @TheDJ wrote:

Nice work. Someone might want to check if different text sizes can be handled a bit better perhaps ? https://en.wikipedia.beta.wmflabs.org/wiki/Phonos#Text_sizes

{F35564149}

Thanks for raising :) I've split this report into T320820: Phonos speaker icon placement moves on increased/reduced font size (though I think there may be another task/patch in progress which would resolve this)

TheresNoTime closed this task as Resolved.Oct 14 2022, 3:24 PM

Done 😸

• JMcLeod_WMF moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-35) board.Oct 17 2022, 7:08 PM
TheresNoTime closed subtask T315491: Add $wgPhonosApiKeyGoogle to PrivateSettings as Resolved.Dec 3 2022, 5:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL