Page MenuHomePhabricator
Create Task
Maniphest T314304

Fix "Map" Example in Wikilambda Sandbox and Enable it in Test
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Error resolving the argument Z10043K3

What should have happened instead?:
The function should have run successfully

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
After fixing this bug, the test should be re-enabled in the extension (WikiLambda/tests/phpunit/integration/API/ApiFunctionCallTest.php) to avoid similar regressions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix scoping for, and enable in integration tests, the Map function example.mediawiki/extensions/WikiLambdamaster+31 -12
Customize query in gerrit

Event Timeline

cmassaro created this task.Aug 1 2022, 2:56 PM
cmassaro updated the task description. (Show Details)Aug 1 2022, 2:58 PM

This test has been broken since 46b0384b6a06292df975cd181f8fa2d589daf74d (in function-orchestrator).

cmassaro added projects: function-orchestrator, WikiLambda.Aug 1 2022, 2:59 PM
DVrandecic moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.Aug 1 2022, 6:39 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
cmassaro added a comment.Aug 3 2022, 8:29 AM

To be clear: the above comment is not a statement of blame (I knowingly encouraged and approved the breaking change); it is just there to help understand what caused the breakage.

gerritbot added a comment.Aug 4 2022, 3:51 PM

Change 820435 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/extensions/WikiLambda@master] Fix scoping for, and enable in integration tests, the Map function example.

https://gerrit.wikimedia.org/r/820435

gerritbot added a project: Patch-For-Review.Aug 4 2022, 3:51 PM
gerritbot added a comment.Aug 4 2022, 4:11 PM

Change 820435 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix scoping for, and enable in integration tests, the Map function example.

https://gerrit.wikimedia.org/r/820435

Maintenance_bot removed a project: Patch-For-Review.Aug 4 2022, 4:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 4 2022, 5:00 PM
cmassaro claimed this task.Aug 10 2022, 12:31 PM

This is now fixed.

cmassaro moved this task from Incoming to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Aug 29 2022, 6:06 PM
DVrandecic closed this task as Resolved.Sep 6 2022, 6:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits