Remove ApiSetMentorWeight
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Aug 2 2022, 10:23 AM

Description

According to Codesearch, action=growthsetmentorweight is not used by GrowthExperiments code (or other MW code). Instead, action=options is used by the weight changing JS. With the switch to the structured mentor list (T264343), this API will no longer work (instead, action=growthmanagementorlist will have to be used). Since it appears to be unused, removing it looks like the best option.

Places to check before removing

Check callers of the API (can be done using event.mediawiki_api_request in Hadoop, or api.log at mwlog1002 (T314361#8123465)
Check user scripts (mwgrep at mwmaint1002) (T314361#8123465)

Acceptance criteria

The action=growthsetmentorweight API is no longer available

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove ApiSetMentorWeight	mediawiki/extensions/GrowthExperiments	master	+0 -108

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Urbanecm_WMF	T272376 Make it possible for admin to remove a mentor when they quit/are blocked
Resolved	Urbanecm_WMF	T264343 Have a special page for mentors to sign up
Resolved	Urbanecm_WMF	T314362 Ensure MentorWeightManager is not used with structured mentor list
Resolved	Urbanecm_WMF	T314361 Remove ApiSetMentorWeight

Event Timeline

Urbanecm_WMF created this task.Aug 2 2022, 10:23 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 2 2022, 10:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Urbanecm_WMF added a parent task: T264343: Have a special page for mentors to sign up.Aug 2 2022, 10:23 AM

Urbanecm_WMF mentioned this in T314362: Ensure MentorWeightManager is not used with structured mentor list.Aug 2 2022, 10:33 AM

API callers:

hive (event)> select count(*) from mediawiki_api_request where year=2022 and month in (8,7) and params['action']='growthsetmentorweight';
[...]
Total MapReduce CPU Time Spent: 7 days 15 hours 27 minutes 26 seconds 920 msec
OK
_c0
0
Time taken: 587.094 seconds, Fetched: 1 row(s)
hive (event)>

Site/user scripts:

[urbanecm@mwmaint1002 ~]$ mwgrep growthsetmentorweight

(total: 0, shown: 0)
[urbanecm@mwmaint1002 ~]$ mwgrep --user growthsetmentorweight

(total: 0, shown: 0)
[urbanecm@mwmaint1002 ~]$

Appears to be unused. Let's remove it.

Urbanecm_WMF renamed this task from Consider removing ApiSetMentorWeight to Remove ApiSetMentorWeight.Aug 2 2022, 12:19 PM

Urbanecm_WMF claimed this task.

Urbanecm_WMF triaged this task as Medium priority.

Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)), User-Urbanecm_WMF (Engineering); removed Growth-Team.

Urbanecm_WMF updated the task description. (Show Details)

Change 819569 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Remove ApiSetMentorWeight

https://gerrit.wikimedia.org/r/819569

gerritbot added a project: Patch-For-Review.Aug 2 2022, 12:24 PM

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 2 2022, 12:26 PM

Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.