Page MenuHomePhabricator
Create Task
Maniphest T314383

Ensure Types Are Fully Resolved before Running Validation Functions
Closed, ResolvedPublic
Actions

Description

In some cases (usually compositions), the type of an object will not be fully resolved before validation is run. Look for TODO (T314383) within the function-orchestrator for details on how this can happen.

Details

SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (194e4da)mediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (194e4da)mediawiki/tools/wikilambda-climaster+1 -1
Update function-schemata sub-module to HEAD (194e4da)mediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (194e4da)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (194e4da)mediawiki/services/function-orchestratormaster+1 -1
definitions: Make list, pair, and map built-in functions instead of compositionsmediawiki/services/function-schematamaster+12 -179
Customize query in gerrit

Related Objects

Event Timeline

cmassaro created this task.Aug 2 2022, 12:38 PM
cmassaro added a project: function-orchestrator.
cmassaro updated the task description. (Show Details)
cmassaro added a comment.Aug 4 2022, 10:25 AM

This is most likely to happen in the case where a user-defined generic function is implemented as a composition, where the types are given as argument references, viz.

{
    'Z1K1': 'Z4',
    [...]
    'Z4K2': [
        'Z3',
        {
            'Z1K1': 'Z3',
            'Z3K1': {
                'Z1K1': 'Z18',
                'Z18K1': 'ZWHATEVK1'
            }
            [...]
        }
    ],
    [...]
}

where ZWHATEVK1 is an argument to the generic function.

gerritbot added a comment.Aug 15 2022, 4:28 PM

Change 822352 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Make list, pair, and map built-in functions instead of compositions.

https://gerrit.wikimedia.org/r/822352

gerritbot added a project: Patch-For-Review.Aug 15 2022, 4:28 PM
gerritbot added a comment.Aug 15 2022, 5:29 PM

Change 822352 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] definitions: Make list, pair, and map built-in functions instead of compositions

https://gerrit.wikimedia.org/r/822352

Jdforrester-WMF mentioned this in rMSFS22aec6865289: definitions: Make list, pair, and map built-in functions instead of compositions.Aug 15 2022, 5:29 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 15 2022, 5:30 PM
gerritbot added a comment.Aug 15 2022, 5:34 PM

Change 823189 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823189

gerritbot added a project: Patch-For-Review.Aug 15 2022, 5:34 PM

Change 823190 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823190

gerritbot added a comment.Aug 15 2022, 5:34 PM

Change 823191 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823191

gerritbot added a comment.Aug 15 2022, 5:34 PM

Change 823192 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823192

gerritbot added a comment.Aug 15 2022, 5:42 PM

Change 823194 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823194

gerritbot added a comment.Aug 15 2022, 5:43 PM

Change 823194 abandoned by Cory Massaro:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (194e4da)

Reason:

https://gerrit.wikimedia.org/r/823194

gerritbot added a comment.Aug 15 2022, 5:46 PM

Change 823191 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823191

Jdforrester-WMF mentioned this in rMSFO0fd0e9eeb62f: Update function-schemata sub-module to HEAD (194e4da).Aug 15 2022, 5:47 PM
gerritbot added a comment.Aug 15 2022, 5:48 PM

Change 823190 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823190

cmassaro claimed this task.Aug 15 2022, 6:04 PM
Jdforrester-WMF mentioned this in rMSFE9b80d0d34b71: Update function-schemata sub-module to HEAD (194e4da).Aug 15 2022, 6:04 PM
gerritbot added a comment.Aug 16 2022, 2:01 PM

Change 823189 merged by jenkins-bot:

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823189

Jdforrester-WMF mentioned this in rMTWCd3303c3b5191: Update function-schemata sub-module to HEAD (194e4da).Aug 16 2022, 2:02 PM
gerritbot added a comment.Aug 16 2022, 2:16 PM

Change 823192 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (194e4da)

https://gerrit.wikimedia.org/r/823192

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 16 2022, 3:00 PM
DVrandecic moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Aug 16 2022, 6:50 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
cmassaro moved this task from Incoming to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Aug 29 2022, 6:06 PM
DVrandecic closed this task as Resolved.Sep 6 2022, 6:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL