Page MenuHomePhabricator
Create Task
Maniphest T314393

Division operation fix for Python 3+
Closed, ResolvedPublic
Actions

Description

During the work on T312919 task, we noticed that tests don't cover such cases where the division operation is used or maybe the value after the division doesn't still break testing logic. Since the division operation works different in Python3, such uses should be checked and replaced in a way which will repeat Python2 behaviour.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove division operation hack related to Python2operations/software/thumbor-pluginsmaster+13 -14
Customize query in gerrit

Event Timeline

roman-stolar created this task.Aug 2 2022, 2:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 2 2022, 2:22 PM
roman-stolar moved this task from To Do to In Progress on the Thumbor Migration board.Aug 2 2022, 2:22 PM
Aklapper added a project: Python3-Porting.Aug 2 2022, 7:01 PM
roman-stolar moved this task from In Progress to To Do on the Thumbor Migration board.Aug 4 2022, 12:40 PM
roman-stolar triaged this task as High priority.Aug 17 2022, 12:18 PM
Vlad.shapik moved this task from To Do to In Progress on the Thumbor Migration board.Aug 25 2022, 5:45 PM
gerritbot added a comment.Sep 8 2022, 5:13 PM

Change 830907 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[operations/software/thumbor-plugins@master] Remove division operation hack related to Python2

https://gerrit.wikimedia.org/r/830907

gerritbot added a project: Patch-For-Review.Sep 8 2022, 5:13 PM
gerritbot added a comment.Sep 13 2022, 2:16 PM

Change 830907 merged by jenkins-bot:

[operations/software/thumbor-plugins@master] Remove division operation hack related to Python2

https://gerrit.wikimedia.org/r/830907

Maintenance_bot removed a project: Patch-For-Review.Sep 13 2022, 2:30 PM
Vlad.shapik moved this task from In Progress to Done on the Thumbor Migration board.Sep 13 2022, 4:46 PM
Vlad.shapik closed this task as Resolved.Jan 31 2023, 1:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits