Page MenuHomePhabricator

Analysis Acceptance tests use wrong database schema
Closed, ResolvedPublic

Description

The AnalysisUseCaseTest loads the files from tests/Data/files/database/, which contain outdated CREATE TABLE statements for donations and memberships. This introduces subtle bugs (e.g. not throwing errors when mixing unbuffered and buffered queries (without re-setting the flag) with the new database schema) and potential wrong analysis (when we drop the amount column from the donation table, the tests will still run)

Acceptance Criteria:

  • The data fixtures for the analysis tests use the existing database schema (set up automatically by the test environment)

Ideally, we make the data fixtures more independent from the database schema by inserting only needed columns.