Grant "enrollasmentor" right automatically according to community's specifications
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Aug 2 2022, 4:42 PM

Description

The Growth-Team is working on a structured mentor list as part of T264343. As part of this project, a new right (enrollasmentor) was introduced, controlling the access to Special:EnrollAsMentor. Currently, communities control "Who can become a mentor" by protecting the pages. With the structured mentor list, this will be covered by the enrollasmentor right.

We need to let communities to define who can have the right as part of community configuration. Communities should be able to configure the minimum user tenure (in days) and minimum edit count to be eligible for the right.

The wording should inform communities that more complex systems are possible, and that the Growth-Team can assist with those on request.

Acceptance criteria

When structured mentor list is enabled, Special:EditGrowthConfig allows communties to define minimum tenure (in days) and minimum edit count required to be able to use Special:EnrollAsMentor.

Details

Subject	Repo	Branch	Lines +/-
Revert "testwiki: Growth: Assign enrollasmentor to *"	operations/mediawiki-config	master	+0 -1
Revert "[beta] Temporarily allow everyone to enroll as mentor"	operations/mediawiki-config	master	+4 -3
Grant "enrollasmentor" to users meeting community's criteria	mediawiki/extensions/GrowthExperiments	master	+216 -19

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Urbanecm_WMF	T272376 Make it possible for admin to remove a mentor when they quit/are blocked
Resolved		Urbanecm_WMF	T264343 Have a special page for mentors to sign up
Resolved		Urbanecm_WMF	T314414 Grant "enrollasmentor" right automatically according to community's specifications
Resolved	BUG REPORT	kostajh	T315489 Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory

Event Timeline

Urbanecm_WMF created this task.Aug 2 2022, 4:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 2 2022, 4:42 PM

Urbanecm_WMF triaged this task as High priority.Aug 2 2022, 4:42 PM

Urbanecm_WMF removed a project: Growth-Scaling.Aug 2 2022, 6:12 PM

Change 819657 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [WIP] Grant "enrollasmentor" to users meeting community's criteria

https://gerrit.wikimedia.org/r/819657

gerritbot added a project: Patch-For-Review.Aug 2 2022, 6:14 PM

Urbanecm_WMF changed the task status from Open to In Progress.Aug 3 2022, 4:11 PM

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

MShilova_WMF moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Aug 9 2022, 3:22 PM

Urbanecm_WMF removed a project: User-Urbanecm_WMF (Engineering).Aug 11 2022, 10:38 AM

Urbanecm_WMF mentioned this in T310905: Deploy structured wikitext mentor list to Wikimedia wikis.Aug 15 2022, 11:14 AM

Tgr changed the task status from In Progress to Open.Aug 17 2022, 1:43 AM

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Adding T315489 as a subtask, so we have a list of tasks with unmerged patches because of that CI issue.

Change 819657 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Grant "enrollasmentor" to users meeting community's criteria

https://gerrit.wikimedia.org/r/819657

Maintenance_bot removed a project: Patch-For-Review.Aug 22 2022, 5:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 22 2022, 6:00 PM

The options are in place - https://test.wikipedia.org/wiki/Special:EditGrowthConfig shows the additional options for Mentorship section:

Screen Shot 2022-08-25 at 5.56.55 PM.png (954×2 px, 196 KB)

However, setting Should users be automatically eligible for mentorship? option to "No, don't allow any users to enroll as mentors." will not prevent users' access to Special:EnrollAsMentor which would silently fail if a user attempts to save the filled out form (see the animated gif below):

enroll-as-mentor-fails.gif (583×1 px, 227 KB)

The same behavior for the option Minimum number of edits users need to be eligible for mentorship.

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 26 2022, 9:15 PM

Change 826622 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Revert "testwiki: Growth: Assign enrollasmentor to *"

https://gerrit.wikimedia.org/r/826622

Change 826623 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Revert "[beta] Temporarily allow everyone to enroll as mentor"

https://gerrit.wikimedia.org/r/826623

Thanks for catching that @Etonkovidova. When deploying structured mentor list to test and beta wikis, I made two configuration patches that were meant to allow everyone to sign up as mentor, but forgot to revert them after the community configuration options were introduced.

I uploaded the reverts, and I'll push them out on Monday. This should make Special:EnrollAsMentor work as expected at beta/test wikis.

Change 826623 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "[beta] Temporarily allow everyone to enroll as mentor"

https://gerrit.wikimedia.org/r/826623

Change 826622 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "testwiki: Growth: Assign enrollasmentor to *"

https://gerrit.wikimedia.org/r/826622

Mentioned in SAL (#wikimedia-operations) [2022-08-29T07:14:38Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 88b3ce8196927d46f13d05aa8f3467992832f09d: Revert "testwiki: Growth: Assign enrollasmentor to *" (T310905, T314414) (duration: 03m 32s)

In T314414#8191122, @Urbanecm_WMF wrote:

Thanks for catching that @Etonkovidova. When deploying structured mentor list to test and beta wikis, I made two configuration patches that were meant to allow everyone to sign up as mentor, but forgot to revert them after the community configuration options were introduced.

I uploaded the reverts, and I'll push them out on Monday. This should make Special:EnrollAsMentor work as expected at beta/test wikis.

This happened. FYI @Etonkovidova .

Maintenance_bot removed a project: Patch-For-Review.Aug 29 2022, 7:30 AM

kostajh closed subtask T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory as Resolved.Oct 18 2022, 3:22 PM

Etonkovidova updated the task description. (Show Details)Oct 22 2022, 12:48 AM

Checked in testwiki wmf.6`

	F35490449: Screen Shot 2022-08-25 at 5.56.55 PM.png
	Aug 26 2022, 1:14 AM

Grant "enrollasmentor" right automatically according to community's specificationsClosed, ResolvedPublicActions