Page MenuHomePhabricator

Don’t follow redirects when editing sitelinks if certain badges are set
Closed, ResolvedPublic

Event Timeline

Change 818184 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Michael Große):

[mediawiki/extensions/Wikibase@master] Allow sitelinks to redirects if redirect badge is present

https://gerrit.wikimedia.org/r/818184

Change 819639 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Add tests for sitelink to redirect behavior

https://gerrit.wikimedia.org/r/819639

Claiming this for now, though credit for the first patch goes to Michael (I moved it around afterwards). If this doesn’t get done before I go on vacation then someone else can claim it again :)

Change 820507 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Set settings properly in SpecialSetSiteLinkTest

https://gerrit.wikimedia.org/r/820507

Change 820507 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Set settings properly in SpecialSetSiteLinkTest

https://gerrit.wikimedia.org/r/820507

Change 818184 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Allow sitelinks to redirects if redirect badge is present

https://gerrit.wikimedia.org/r/818184

Back to Doing for the tests (though the parent task may move into verification soonish).

Change 820750 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Don't allow a redirect badge on a sitelink to a redirect be removed

https://gerrit.wikimedia.org/r/820750

Change 820437 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Run sitelink on redirects tests for wbeditentity as well

https://gerrit.wikimedia.org/r/820437

Change 819639 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add tests for sitelink to redirect behavior

https://gerrit.wikimedia.org/r/819639

Change 820437 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Run sitelink on redirects tests for wbeditentity as well

https://gerrit.wikimedia.org/r/820437

This is now done and has tests and has been cleaned up. We could/should maybe still think about browser tests for the special page? Maybe that is already covered by the special-page integration tests?

Michael claimed this task.