InvalidArgumentException: Wikimedia\Rdbms\JoinGroupBase::addJoin: $table must be either string, JoinGroup or SelectQueryBuilder
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	dancy
	Aug 2 2022, 8:57 PM

Description

Error

mwversion: 1.39.0-wmf.23
reqId: 2365b6a1b49751951638ef6a
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   InvalidArgumentException: Wikimedia\Rdbms\JoinGroupBase::addJoin: $table must be either string, JoinGroup or SelectQueryBuilder

exception.trace

from /srv/mediawiki/php-1.39.0-wmf.23/includes/libs/rdbms/querybuilder/JoinGroupBase.php(138)
#0 /srv/mediawiki/php-1.39.0-wmf.23/includes/libs/rdbms/querybuilder/JoinGroupBase.php(81): Wikimedia\Rdbms\JoinGroupBase->addJoin(string, array, string, array)
#1 /srv/mediawiki/php-1.39.0-wmf.23/extensions/CirrusSearch/includes/Sanity/Checker.php(332): Wikimedia\Rdbms\JoinGroupBase->join(array)
#2 /srv/mediawiki/php-1.39.0-wmf.23/extensions/CirrusSearch/includes/Sanity/Checker.php(122): CirrusSearch\Sanity\Checker->loadPagesFromDB(array)
#3 /srv/mediawiki/php-1.39.0-wmf.23/extensions/CirrusSearch/includes/Job/CheckerJob.php(234): CirrusSearch\Sanity\Checker->check(array)
#4 /srv/mediawiki/php-1.39.0-wmf.23/extensions/CirrusSearch/includes/Job/JobTraits.php(138): CirrusSearch\Job\CheckerJob->doJob()
#5 /srv/mediawiki/php-1.39.0-wmf.23/extensions/EventBus/includes/JobExecutor.php(79): CirrusSearch\Job\CirrusGenericJob->run()
#6 /srv/mediawiki/rpc/RunSingleJob.php(77): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#7 {main}

Notes

1179 of these occurred immediately after rolling to group0 today so I rolled back.

Details

Request URL: https://jobrunner.discovery.wmnet/rpc/RunSingleJob.php

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/CirrusSearch	master	+1 -1	Fix appending of join conds
	mediawiki/extensions/CirrusSearch	wmf/1.39.0-wmf.23	+1 -1	Fix appending of join conds

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	dancy	T308076 1.39.0-wmf.23 deployment blockers
		Resolved	PRODUCTION ERROR	Zabe	T314439 InvalidArgumentException: Wikimedia\Rdbms\JoinGroupBase::addJoin: $table must be either string, JoinGroup or SelectQueryBuilder

Event Timeline

dancy triaged this task as Unbreak Now! priority.Aug 2 2022, 8:57 PM

dancy created this task.

Restricted Application added a project: Discovery-Search. · View Herald TranscriptAug 2 2022, 8:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Zabe added a subscriber: Zabe.Aug 2 2022, 8:58 PM

Change 819746 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CirrusSearch@master] Fix appending of join conds

https://gerrit.wikimedia.org/r/819746

gerritbot added a project: Patch-For-Review.Aug 2 2022, 8:58 PM

dancy added a parent task: T308076: 1.39.0-wmf.23 deployment blockers.Aug 2 2022, 8:58 PM

Zabe claimed this task.Aug 2 2022, 8:59 PM

Change 819621 had a related patch set uploaded (by Ladsgroup; author: Zabe):

[mediawiki/extensions/CirrusSearch@wmf/1.39.0-wmf.23] Fix appending of join conds

https://gerrit.wikimedia.org/r/819621

Change 819621 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@wmf/1.39.0-wmf.23] Fix appending of join conds

https://gerrit.wikimedia.org/r/819621

Mentioned in SAL (#wikimedia-operations) [2022-08-02T21:29:13Z] <ladsgroup@deploy1002> Synchronized php-1.39.0-wmf.23/extensions/CirrusSearch/includes/Sanity/Checker.php: Backport: [[gerrit:819621|Fix appending of join conds (T312421 T314439)]] (duration: 03m 15s)