Wikibase CI errors: Cannot declare class HooksTest, because the name is already in use
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Aug 3 2022, 9:41 AM

Description

E.g. in this wikibase-client-docker build for gate-and-submit in this Wikibase change:

PHP Fatal error:  Cannot declare class HooksTest, because the name is already in use in /workspace/src/extensions/Scribunto/tests/phpunit/HooksTest.php on line 5

Probably caused by this Scribunto change, which “namespace[d] LuaCommon” and renamed ScribuntoHooksTest to HooksTest without actually adding a namespace to it; the other \HooksTest class is probably in core.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Revert "Namespace LuaCommon"	mediawiki/extensions/Scribunto	master	+241 -329
	Add namespace to HooksTest	mediawiki/extensions/Scribunto	master	+7 -2

Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Aug 3 2022, 9:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2022, 9:41 AM

Blocks CI, probably for more than one extension ⇒ UBN!

WMDE-leszek subscribed.Aug 3 2022, 9:43 AM

Change 820093 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Scribunto@master] Add namespace to HooksTest

https://gerrit.wikimedia.org/r/820093

gerritbot added a project: Patch-For-Review.Aug 3 2022, 9:46 AM

Lucas_Werkmeister_WMDE claimed this task.Aug 3 2022, 9:46 AM

Change 819793 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Scribunto@master] Revert "Namespace LuaCommon"

https://gerrit.wikimedia.org/r/819793

Michael subscribed.Aug 3 2022, 10:21 AM

Change 819793 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Revert "Namespace LuaCommon"

https://gerrit.wikimedia.org/r/819793

Change 820093 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Scribunto@master] Add namespace to HooksTest

Reason:

we reverted the whole change instead (I8b15132723)

https://gerrit.wikimedia.org/r/820093

Probably fixed, so no longer UBN; will close once a Wikibase change goes through gate-and-submit. (And then @Reedy and @Krinkle will want to retry the namespacing, I guess – it would be great to test it with a depending Wikibase change this time.)

Wikibase CI seems to be fixed again.

Wikibase CI errors: Cannot declare class HooksTest, because the name is already in useClosed, ResolvedPublicActions

Description

Details

Event Timeline

Wikibase CI errors: Cannot declare class HooksTest, because the name is already in use
Closed, ResolvedPublic
Actions