Page MenuHomePhabricator

I18n: Make use of {{PLURAL}} in messages
Closed, InvalidPublic

Description

When translating the messages, there are places that may look good-enough in English but they would benefit a lot from possibility of using parser functions that adjust grammar forms of words.

Some examples are:

Event Timeline

Teleosteen subscribed.

Using Vim, I edited the i18n/en.json file to check if there were other keys for which the translations were in the case described by the issue. I failed to find others, here is my methodology:

  • open the file using neovim (or vim, it will work as well): nvim i18n/en.json
  • search translation having caracters others than alphanumerics, spaces (of any form), punctuation mark, colon, dollar and single quote: /\wikilambda[^"]*": \".*\zs[^[:alnum:][:space:]\.\,\$\']\ze.*"
  • for each match, read the whole line (because some match may occur due to the greedy .*

So the only translation keys concerned the issue I detected are:

  • wikilambda-editor-fn-step-tests
  • wikilambda-editor-fn-step-implementations

However I failed to find any place in the code where the two keys were used. Probably worth to remove them unless I made a mistake.

Normally it will eventually be fixed along with T320723

@Jdforrester-WMF As T320723 is merged, I think this issue can be set as resolved. Do you need me to do this (now and in the future)? Or should I let someone like you do this?

@Jdforrester-WMF As T320723 is merged, I think this issue can be set as resolved. Do you need me to do this (now and in the future)? Or should I let someone like you do this?

You can do it, that's fine. :-) I've set it to Invalid instead, because the messages this refers to no longer exist.