Template previews are broken in VisualEditor (on non-RESTBase wikis?)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Aug 3 2022, 7:18 PM

Description

Template previews are broken in VisualEditor. This might only affect non-RESTBase wikis (I can't reproduce at https://www.mediawiki.org/).

Steps to reproduce:

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/VisualEditor	wmf/1.39.0-wmf.23	+14 -1	Update call to PageConfigFactory::create to use new signature
	mediawiki/extensions/VisualEditor	master	+14 -1	Update call to PageConfigFactory::create to use new signature

Mentioned Here: rEVEDa804fe18f1e1: Update call to PageConfigFactory::create to use new signature
rMW9bd7d5b3241a: Remove $wikitextOverride argument to PageConfigFactory::create()

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2022, 7:18 PM

The backend issue also presents in the new topic / reply tool:

Visit https://wikitech.wikimedia.org/wiki/Talk:Deployments
Open the new topic tool, in source mode
Type something
Switch to visual mode – anything you typed is replaced by a copy of the entire page

Change 820211 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/VisualEditor@master] Update call to PageConfigFactory::create to use new signature

Change 820194 had a related patch set uploaded (by Bartosz Dziewoński; author: Subramanya Sastry):

[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.23] Update call to PageConfigFactory::create to use new signature

Change 820211 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update call to PageConfigFactory::create to use new signature

Change 820194 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.23] Update call to PageConfigFactory::create to use new signature

Mentioned in SAL (#wikimedia-operations) [2022-08-03T20:43:19Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.23/extensions/VisualEditor/includes/VisualEditorParsoidClient.php: a804fe18f1e14795ba7836d3ebf6c361bb1538a7: Update call to PageConfigFactory::create to use new signature (T314523) (duration: 03m 25s)

ssastry closed this task as Resolved.Aug 3 2022, 9:45 PM

ssastry claimed this task.

	F35392274: image.png
	Aug 3 2022, 7:22 PM

	F35392270: image.png
	Aug 3 2022, 7:22 PM

	F35392268: image.png
	Aug 3 2022, 7:22 PM

	F35392277: image.png
	Aug 3 2022, 7:22 PM