Page MenuHomePhabricator

Template previews are broken in VisualEditor (on non-RESTBase wikis?)
Closed, ResolvedPublic

Assigned To
Authored By
matmarex
Wed, Aug 3, 7:18 PM
Referenced Files
F35392274: image.png
Wed, Aug 3, 7:22 PM
F35392270: image.png
Wed, Aug 3, 7:22 PM
F35392268: image.png
Wed, Aug 3, 7:22 PM
F35392277: image.png
Wed, Aug 3, 7:22 PM
F35392262: image.png
Wed, Aug 3, 7:18 PM
F35392260: image.png
Wed, Aug 3, 7:18 PM
F35392258: image.png
Wed, Aug 3, 7:18 PM
F35392264: image.png
Wed, Aug 3, 7:18 PM
Subscribers

Description

Template previews are broken in VisualEditor. This might only affect non-RESTBase wikis (I can't reproduce at https://www.mediawiki.org/).

Steps to reproduce:

  1. Visit https://wikitech.wikimedia.org/wiki/Deployments?veaction=edit
    image.png (2×3 px, 705 KB)
  2. Make changes to any of the "Deployment calendar event card" templates
    image.png (2×3 px, 374 KB)
    image.png (2×3 px, 400 KB)
  3. The preview is replaced with a copy of the entire page!
    image.png (2×3 px, 625 KB)

Event Timeline

The backend issue also presents in the new topic / reply tool:

  1. Visit https://wikitech.wikimedia.org/wiki/Talk:Deployments
    image.png (2×3 px, 728 KB)
  2. Open the new topic tool, in source mode
    image.png (2×3 px, 467 KB)
  3. Type something
    image.png (2×3 px, 410 KB)
  4. Switch to visual mode – anything you typed is replaced by a copy of the entire page
    image.png (2×3 px, 526 KB)

Change 820211 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/VisualEditor@master] Update call to PageConfigFactory::create to use new signature

https://gerrit.wikimedia.org/r/820211

Change 820194 had a related patch set uploaded (by Bartosz Dziewoński; author: Subramanya Sastry):

[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.23] Update call to PageConfigFactory::create to use new signature

https://gerrit.wikimedia.org/r/820194

Change 820211 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update call to PageConfigFactory::create to use new signature

https://gerrit.wikimedia.org/r/820211

Change 820194 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.23] Update call to PageConfigFactory::create to use new signature

https://gerrit.wikimedia.org/r/820194

Mentioned in SAL (#wikimedia-operations) [2022-08-03T20:43:19Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.23/extensions/VisualEditor/includes/VisualEditorParsoidClient.php: a804fe18f1e14795ba7836d3ebf6c361bb1538a7: Update call to PageConfigFactory::create to use new signature (T314523) (duration: 03m 25s)

ssastry claimed this task.