Page MenuHomePhabricator

[EPIC] Add Accordion component to Codex
Closed, InvalidPublic

Assigned To
None
Authored By
Sarai-WMDE
Aug 4 2022, 12:03 PM
Referenced Files
F36578539: image.png
Feb 2 2023, 9:48 AM
F35887929: Accordion.png
Dec 22 2022, 6:03 PM
F35886225: CleanShot 2022-12-21 at 19.30.57.gif
Dec 22 2022, 5:58 PM
F34409486: image.png
Dec 22 2022, 5:48 PM
F35518016: Screen Shot 2022-09-12 at 8.04.41 PM.png
Dec 22 2022, 5:48 PM
F34409484: image.png
Dec 22 2022, 5:48 PM
F34409481: image.png
Dec 22 2022, 5:48 PM
File Not Attached
F34409478: image.png
Dec 22 2022, 5:48 PM
File Not Attached

Description

Background

  • Description: Accordions present one or more content areas that can be expanded and collapsed.
  • History: There's a main task with an inventory of potential accordion instances that should be taken into consideration when tackling the definition of this pattern: T280785: Define and add the expand and collapse (accordion) component to the DSG.
  • Considerations: This pattern should be approved by the design team before being introduced in our design system. The DST needs to decide if Accordion should be considered a core system component.
  • Known use case(s): The first potential consumer of the Accordion component would be Abstract Wikipedia, in the context of their "Default component". There are several variations of expand/collapse elements in the Wikimedia interfaces, from article sections in Minerva, to tree-like menus in Vector's table of content. We need to decide, as part of the definition of the Accordion, whether these other collapse/expand elements will need any adjustments.
Main use cases:
Minerva content sections collapsed by default
image.png (740×810 px, 37 KB)
Expanded
image.png (810×812 px, 117 KB)
Vector Tools panel (Prototype)
Captura de Pantalla 2022-12-16 a las 12.24.13.png (1×1 px, 730 KB)
Expanded
Captura de Pantalla 2022-12-16 a las 12.24.20.png (1×1 px, 713 KB)
Wikifunctions T323013
Captura de Pantalla 2022-12-16 a las 12.04.46.png (1×600 px, 355 KB)
Other expand/collapse use cases:
Screen Shot 2022-06-27 at 12.45.57 PM.png (541×591 px, 101 KB)
CleanShot 2022-12-21 at 19.30.57.gif (352×800 px, 3 MB)
image.png (624×634 px, 67 KB)
image.png (474×626 px, 62 KB)
Screen Shot 2022-09-12 at 8.04.41 PM.png (1×2 px, 181 KB)
image.png (284×656 px, 95 KB)
image.png (1×950 px, 116 KB)
Vector 2022 toc sections (this is a TreeView instead T325351)VE to display Wikidata entitiesVE droplist menuVE templates selector (doesn’t enable collapse)Search/filter component on many Special pagesExpand/collapse links in legend/key tables on Watchlist and other Special pagesGrowth structured tasks (mobile) - sticky bottom sheet can expand and collapse.

User stories

  • As a designer and developer, I want to be able to reuse an accordion component to group relevant content and present a clean structure to users.

Previous implementations

These artifacts are listed for historical context. The figma spec, linked below, is the source of truth for the new component.

  • Design style guide: Pending. See T280785
  • OOUI: -
  • Vue: -

Codex implementation

Component task owners

  • Designer: add the main deigner's name
  • Developer: add the main developer's name

Design spec

WIP. A component spec sheet has not been created yet.

Component spec sheet

Stage 1: Minimum viable product (MVP)

MVP includes basic layout, default states, and most important functionality.

Acceptance criteria

  • Determine what MVP includes for this component and document this in a subtask. Assign task to designer.
  • Design MVP. Once complete, assign task to developer.
  • Implement MVP

Stage 2: Additional states, features, and variants

Acceptance criteria

  • Document design and implementation of additional states and features in individual subtasks
  • Complete each additional state/feature subtask

Stage 3: Refinement

Acceptance criteria

  • Finalize docs: open and complete a subtask for any additional demos that need to be added or documentation that needs work
  • Meet accessibility standards: open and complete a subtask for any necessary accessibility improvements
  • Meet internationalization standards: open and complete a subtask to fix any i18n bugs
  • Complete testing: open and complete a subtask for any additional unit or functional tests that are needed

Event Timeline

egardner renamed this task from Design and build Accordion component to [EPIC] Design and build Accordion component.Dec 21 2022, 6:34 PM
bmartinezcalvo renamed this task from [EPIC] Design and build Accordion component to [EPIC] Add Accordion component to Codex.Dec 22 2022, 5:48 PM
bmartinezcalvo updated the task description. (Show Details)
bmartinezcalvo updated the task description. (Show Details)

@AAlhazwani-WMF during our DST Engineering/Design sync yesterday we discussed about your nested component for AW T323013 and it seems that it would be finally an accordion component since an accordion could have another accordion inside.

Accordion.png (554×628 px, 10 KB)

I will remove your use case from T325351. So we'll move our conversations about your component to this task.

ldelench_wmf subscribed.

The Design Systems team is removing the majority of our "meta" tasks like this one. Follow this work in T326665.