Page MenuHomePhabricator

flake8-logging-format broken with flake8 5.x, breaking tools-webservice build
Closed, ResolvedPublic

Description

Flake8 5.x breaks flake8-logging-format:

plugin code for `flake8-logging-format[logging-format]` does not match ^[A-Z]{1,3}[0-9]{0,3}$

Right now we're working around that by pinning tox.ini to use flake8 4. There's a merged but not-yet-unreleased upstream fix: https://github.com/globality-corp/flake8-logging-format/pull/33.

Event Timeline

Change 868789 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/software/tools-webservice@master] tox: revert flake8 4.x pinning

https://gerrit.wikimedia.org/r/868789

Change 868789 merged by jenkins-bot:

[operations/software/tools-webservice@master] tox: revert flake8 4.x pinning

https://gerrit.wikimedia.org/r/868789

taavi claimed this task.