Make `ApiFunctionCallTest.php` compare expected vs. received values
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	Aug 4 2022, 3:50 PM

Description

The tests in this file currently don't do anything, i.e. there's no assertion that the expected and received values match. There should be such an assertion!

Details

	Subject	Repo	Branch	Lines +/-
	Put test assertions in function call API integration test.	mediawiki/extensions/WikiLambda	master	+62 -41

Customize query in gerrit

Event Timeline

cmassaro created this task.Aug 4 2022, 3:50 PM

Change 820514 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/extensions/WikiLambda@master] Put test assertions in function call API integration test.

https://gerrit.wikimedia.org/r/820514

gerritbot added a project: Patch-For-Review.Aug 4 2022, 5:09 PM

Change 820514 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Put test assertions in function call API integration test.

https://gerrit.wikimedia.org/r/820514

Maintenance_bot removed a project: Patch-For-Review.Aug 11 2022, 3:29 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 11 2022, 4:00 PM

Jdforrester-WMF moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Aug 11 2022, 4:39 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

Effectively reverted in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/822632 :-(

Jdforrester-WMF closed this task as Resolved.Nov 2 2022, 9:49 PM

Jdforrester-WMF claimed this task.

Make `ApiFunctionCallTest.php` compare expected vs. received valuesClosed, ResolvedPublicActions

Description

Details

Event Timeline

Make `ApiFunctionCallTest.php` compare expected vs. received values
Closed, ResolvedPublic
Actions