Page MenuHomePhabricator

[Visual refinements] Do not flip arrows on menu handles
Open, MediumPublic2 Estimated Story Points

Description

Description

The design team has provided the following guidance regarding flipping arrows on menu handles:

dropdown elements can be used in a variety of contexts and positions in a layout, and are not immune to scroll. In some scenarios (e.g. based on the user's scroll position), it might be necessary to flip the vertical direction of menus (open them upwards) in order to keep them in above the fold. Keeping the indicator uniformly pointing down will save us the need to implement extra (potentially distracting) transitions to cover all the scenarios (e.g. changing the orientation of the handle icon based on the mentioned scroll position instead of on a user action).

(additional context here)

To-do

  • Do not flip arrows on menu handles in Vector 2022
  • Flip them in Vector
user menumore menulanguage variant menutwinkle
Screen Shot 2022-08-05 at 11.22.04 AM.png (106×138 px, 10 KB)
Screen Shot 2022-08-05 at 11.22.08 AM.png (80×124 px, 9 KB)
Screen Shot 2022-08-05 at 11.22.37 AM.png (82×154 px, 11 KB)
Screen Shot 2022-08-05 at 11.22.12 AM.png (82×116 px, 9 KB)

QA

  • In old Vector make sure the arrows are flipped (ie. no change)

Event Timeline

The flip occurs with a rule transform: scaleY(-1); so should be straightforward to remove.

bwang removed bwang as the assignee of this task.Tue, Aug 16, 8:22 PM
bwang added a subscriber: bwang.

Change 823739 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Prevent dropdown arrow from flipping in modern Vector

https://gerrit.wikimedia.org/r/823739

Change 823739 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Prevent dropdown arrow from flipping in modern Vector

https://gerrit.wikimedia.org/r/823739