Page MenuHomePhabricator

Add support for links migration to namespaceDupes.php
Closed, ResolvedPublic

Description

Currently, namespaceDupes.php checks only the namespace and title columns of the page, pagelinks, templatelinks, and redirect tables. It does not currently check the linktarget table and will need to be updated for the links migration.

According to wikitech:Backport windows/Deployers, "When a new namespace is added to an existing [Wikimedia] wiki, the namespaceDupes maintenance script should be run for that wiki." This has been done several times since the start of the links migration. While it's possible that in some cases there may have been template link targets that the script failed to properly update, the bigger issue is that once the tl_namespace and tl_title columns are dropped, the script will fail with a database query error before it even starts checking the pagelinks table for the prefixes corresponding to the newly added namespace.

Event Timeline

Change 821783 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] maintenance: Add support for links migration to namespaceDupes.php

https://gerrit.wikimedia.org/r/821783

Change 821734 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@wmf/1.39.0-wmf.23] maintenance: Add support for links migration to namespaceDupes.php

https://gerrit.wikimedia.org/r/821734

Change 821783 merged by jenkins-bot:

[mediawiki/core@master] maintenance: Add support for links migration to namespaceDupes.php

https://gerrit.wikimedia.org/r/821783

Change 821734 merged by jenkins-bot:

[mediawiki/core@wmf/1.39.0-wmf.23] maintenance: Add support for links migration to namespaceDupes.php

https://gerrit.wikimedia.org/r/821734

Mentioned in SAL (#wikimedia-operations) [2022-08-10T09:15:56Z] <ladsgroup@deploy1002> Synchronized php-1.39.0-wmf.23/maintenance/namespaceDupes.php: Backport: [[gerrit:821734|maintenance: Add support for links migration to namespaceDupes.php (T314711)]] (duration: 03m 18s)

Change 822055 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/core@master] namespaceDupes.php: Correctly build $setValue for templatelinks

https://gerrit.wikimedia.org/r/822055

Ladsgroup moved this task from In progress to Done on the DBA board.

I resolve this while it has a patch connected, the patch is not really related to the ticket. It's a follow-up for clean ups.