Page MenuHomePhabricator

Precondition failed: This Title instance does not represent a proper page, but merely a link target (from fixDoubleRedirects.php)
Closed, ResolvedPublicPRODUCTION ERROR

Description

Related to T314733: redirects from the transfer of pages between namespaces that already appear on the site in hewikisource

reedy@deploy1002:~$ mwscript fixDoubleRedirects.php --wiki=hewikisource
Wikimedia\Assert\PreconditionException from line 49 of /srv/mediawiki-staging/php-1.39.0-wmf.23/vendor/wikimedia/assert/src/Assert.php: Precondition failed: This Title instance does not represent a proper page, but merely a link target.
#0 /srv/mediawiki-staging/php-1.39.0-wmf.23/includes/Title.php(4182): Wikimedia\Assert\Assert::precondition(false, 'This Title inst...')
#1 /srv/mediawiki-staging/php-1.39.0-wmf.23/includes/Title.php(4163): Title->assertProperPage()
#2 /srv/mediawiki-staging/php-1.39.0-wmf.23/includes/Revision/RevisionStore.php(1828): Title->getId(false)
#3 /srv/mediawiki-staging/php-1.39.0-wmf.23/includes/Revision/RevisionStore.php(1733): MediaWiki\Revision\RevisionStore->ensureRevisionRowMatchesPage(Object(stdClass), Object(Title))
#4 /srv/mediawiki-staging/php-1.39.0-wmf.23/includes/Revision/RevisionStore.php(1609): MediaWiki\Revision\RevisionStore->newRevisionFromRowAndSlots(Object(stdClass), NULL, 1, Object(Title), false)
#5 /srv/mediawiki-staging/php-1.39.0-wmf.23/includes/Revision/RevisionStore.php(2348): MediaWiki\Revision\RevisionStore->newRevisionFromRow(Object(stdClass), 1, Object(Title))
#6 /srv/mediawiki-staging/php-1.39.0-wmf.23/includes/Revision/RevisionStore.php(1286): MediaWiki\Revision\RevisionStore->loadRevisionFromConds(Object(Wikimedia\Rdbms\DBConnRef), Array, 1, Object(Title))
#7 /srv/mediawiki-staging/php-1.39.0-wmf.23/includes/jobqueue/jobs/DoubleRedirectJob.php(122): MediaWiki\Revision\RevisionStore->getRevisionByTitle(Object(Title), 0, 1)
#8 /srv/mediawiki-staging/php-1.39.0-wmf.23/maintenance/fixDoubleRedirects.php(111): DoubleRedirectJob->run()
#9 /srv/mediawiki-staging/php-1.39.0-wmf.23/maintenance/includes/MaintenanceRunner.php(309): FixDoubleRedirects->execute()
#10 /srv/mediawiki-staging/php-1.39.0-wmf.23/maintenance/doMaintenance.php(85): MediaWiki\Maintenance\MaintenanceRunner->run()
#11 /srv/mediawiki-staging/php-1.39.0-wmf.23/maintenance/fixDoubleRedirects.php(142): require_once('/srv/mediawiki-...')
#12 /srv/mediawiki-staging/multiversion/MWScript.php(120): require_once('/srv/mediawiki-...')
#13 {main}

Event Timeline

Aklapper changed the subtype of this task from "Task" to "Production Error".Sep 30 2022, 7:36 PM

Change 838246 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] fixDoubleRedirects.php: Work only with proper titles

https://gerrit.wikimedia.org/r/838246

Umherirrender renamed this task from Precondition failed: This Title instance does not represent a proper page, but merely a link target to Precondition failed: This Title instance does not represent a proper page, but merely a link target (from fixDoubleRedirects.php).Oct 4 2022, 9:12 PM

Change 838246 merged by jenkins-bot:

[mediawiki/core@master] fixDoubleRedirects.php: Work only with proper titles

https://gerrit.wikimedia.org/r/838246