Page MenuHomePhabricator

Flow edits don’t appear when viewing contributions for a CIDR range
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Go to the contributions page of an IP contributor who has made flow edits.
  • Go to a CIDR range containing their IP.

What happens?: Only regular (non-flow) edits appear.

What should have happened instead?: All edits (including flow) should appear.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

image.png (1×2 px, 432 KB)

image.png (1×2 px, 672 KB)

Event Timeline

Ilovemydoodle renamed this task from Flow edit don’t show up for CIDR range to Flow edits don’t appear when viewing contributions for a CIDR range.Aug 7 2022, 9:26 PM
Ilovemydoodle updated the task description. (Show Details)
Reedy subscribed.

Please don't upload images to random third party websites; these can be simply uploaded to Phabricator directly...

@Etonkovidova any idea if this is a regression?

@KStoller-WMF according to our maintenance criteria, we'd work on this "if the issue is urgent, affects a large number of users and needs to be unbroken immediately." It doesn't seem great that Flow posts made by anonymous users don't show up in Special:Contributions in this circumstance, but at least they show up when passing a specific IP address (rather than a CIDR range). So I think we should place this in Triaged, for now.

(Tagging Moderator-Tools-Team in case they're interested in this bug.)

@Etonkovidova any idea if this is a regression?

It doesn't seems so. However, contributions on Flow pages from users with IP addresses in CIDR format were not considered during the testing.

I re-checked (just in case) anon editing on Flow based pages

  • creating a new topic (a title + a post)
  • updating a topic title
  • replying to a post
  • edit a summary
  • update a board description

All edits above are correctly displayed on Special:Contributions page.

Additionally, I checked whether our testing environment has users in CIDR format - there were none

We discussed in Growth engineers meeting, and we're moving to triaged as we have too many other tasks going on right now. Patches welcome. If others feel like this should be prioritized, please let us know.

This could be fairly problematic when dealing with IPv6 abuse, as IPv6 adresses are almost always dynamic and typically you need to filter to the /64 to see all the person's contributions.