Grid blowout on various pages with long elements
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 8 2022, 7:45 AM

Description

Steps to replicate the issue (include links if applicable):

Go to https://vi.wikipedia.org/w/index.php?title=Th%E1%BB%83_lo%E1%BA%A1i:B%C3%A0i_vi%E1%BA%BFt_ch%E1%BB%A9a_nh%E1%BA%ADn_d%E1%BA%A1ng_LCCN&oldid=64974295

What happens?:

Horizontal scrollbar

What should have happened instead?:

No horizontal scrollbar

Acceptance criteria

To fix let's add min-width: 0; to .mw-content-container.
Add an inline comment explaining the change (https://css-tricks.com/preventing-a-grid-blowout/)

QA steps

As well as the example given in this ticket, pull in the following tickets for QA:

QA Results - Prod

AC	Status	Details
1	✅	T314756#8151570

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix grid blowout bug	mediawiki/skins/Vector	wmf/1.39.0-wmf.23	+3 -1
	Fix grid blowout bug	mediawiki/skins/Vector	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned In: T314467: Infinite horizontal scroll when using horizontal resizer
T314567: WikiEditor way too wide in Vector 2022 when there is a long line without linebreaks
Mentioned Here: T314467: Infinite horizontal scroll when using horizontal resizer
T314567: WikiEditor way too wide in Vector 2022 when there is a long line without linebreaks

Event Timeline

Jdlrobson created this task.Aug 8 2022, 7:45 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2022, 7:45 AM

@ovasileva possibly UBN as we're getting reports of this issue on various pages.

Jdlrobson mentioned this in T314567: WikiEditor way too wide in Vector 2022 when there is a long line without linebreaks.Aug 8 2022, 7:47 AM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.

LGoto assigned this task to bwang.Aug 8 2022, 5:48 PM

LGoto set the point value for this task to 2.

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.Aug 8 2022, 5:49 PM

Change 821288 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix grid blowout bug

https://gerrit.wikimedia.org/r/821288

gerritbot added a project: Patch-For-Review.Aug 8 2022, 6:00 PM

bwang removed bwang as the assignee of this task.Aug 8 2022, 6:00 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.

bwang subscribed.

Change 821243 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.39.0-wmf.23] Fix grid blowout bug

https://gerrit.wikimedia.org/r/821243

scheduled for backport in 1.5 hrs

Change 821288 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix grid blowout bug

https://gerrit.wikimedia.org/r/821288

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 8 2022, 7:00 PM

Change 821243 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.39.0-wmf.23] Fix grid blowout bug

https://gerrit.wikimedia.org/r/821243

Mentioned in SAL (#wikimedia-operations) [2022-08-08T20:27:34Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.23/skins/Vector/resources/skins.vector.styles/layouts/grid.less: Backport: [[gerrit:821243|Fix grid blowout bug (T314756)]] (duration: 03m 26s)