Page MenuHomePhabricator
Create Task
Maniphest T314769

Add typehints to Statement and StatementList classes
Closed, ResolvedPublic
Actions

Description

The Wikibase Product Platform team got caught out due to the Wikibase Data Model not having any native type hints.
Adding type hints to the Statement and StatementList classes will solve this specific issue we ran into and give us a good idea on the complexity involved in type hinting the rest of the Wikibase Data Model.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
DM: Add type hints to Statementmediawiki/extensions/Wikibasemaster+58 -102
DM: Add type hints to StatementListmediawiki/extensions/Wikibasemaster+148 -215
[DNM] DM: Remove explicit type checksmediawiki/extensions/Wikibasemaster+8 -28
[DNM] DM: Add type hints to Statement and StatementListmediawiki/extensions/Wikibasemaster+119 -111
[DNM] DM: Remove StatementList deprecated functionalitymediawiki/extensions/Wikibasemaster+117 -123
[DNM] DM: Remove Statement deprecated functionalitymediawiki/extensions/Wikibasemaster+20 -17
DM: Improve StatementTest and StatementListTestmediawiki/extensions/Wikibasemaster+75 -74
[DNM] DM: Add type hints to Statement and StatementListmediawiki/extensions/WikibaseLexememaster+2 -2
Customize query in gerrit

Event Timeline

WMDE-leszek created this task.Aug 8 2022, 9:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2022, 9:37 AM
Ollie.Shotton_WMDE claimed this task.Aug 16 2022, 3:15 PM
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Summer 2022 Not A Sprint) board.
gerritbot added a comment.Aug 17 2022, 6:19 PM

Change 824254 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] DM: Improve StatementTest and StatementListTest

https://gerrit.wikimedia.org/r/824254

gerritbot added a project: Patch-For-Review.Aug 17 2022, 6:19 PM
gerritbot added a comment.Aug 17 2022, 6:21 PM

Change 824256 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] [DNM] DM: Remove Statement deprecated functionality

https://gerrit.wikimedia.org/r/824256

gerritbot added a comment.Aug 17 2022, 6:21 PM

Change 824257 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] [DNM] DM: Remove StatementList deprecated functionality

https://gerrit.wikimedia.org/r/824257

gerritbot added a comment.Aug 17 2022, 7:52 PM

Change 824275 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/WikibaseLexeme@master] [DNM] DM: Remove StatementList deprecated functionality

https://gerrit.wikimedia.org/r/824275

gerritbot added a comment.Aug 17 2022, 7:52 PM

Change 824276 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/WikibaseLexeme@master] [DNM] DM: Add type hints to Statement and StatementList

https://gerrit.wikimedia.org/r/824276

gerritbot added a comment.Aug 17 2022, 8:01 PM

Change 824282 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] [DNM] DM: Remove explicit type checks

https://gerrit.wikimedia.org/r/824282

gerritbot added a comment.Aug 17 2022, 8:23 PM

Change 824276 abandoned by Ollie Shotton:

[mediawiki/extensions/WikibaseLexeme@master] [DNM] DM: Add type hints to Statement and StatementList

Reason:

squashed into parent commit

https://gerrit.wikimedia.org/r/824276

gerritbot added a comment.Aug 17 2022, 9:02 PM

Change 824281 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] [DNM] DM: Add type hints to Statement and StatementList

https://gerrit.wikimedia.org/r/824281

gerritbot added a comment.Aug 19 2022, 9:30 AM

Change 824254 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] DM: Improve StatementTest and StatementListTest

https://gerrit.wikimedia.org/r/824254

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 19 2022, 10:00 AM
Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Summer 2022 Not A Sprint) board.Aug 19 2022, 11:43 AM
WMDE-leszek edited projects, added: Wikibase Product Platform (v1) (Sprint 12); removed: Wikibase Product Platform (v1) (Summer 2022 Not A Sprint).Aug 24 2022, 10:43 AM
WMDE-leszek moved this task from To Do to Peer Review on the Wikibase Product Platform (v1) (Sprint 12) board.
gerritbot added a comment.Aug 31 2022, 1:09 PM

Change 828519 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] DM: Add type hints to Statement

https://gerrit.wikimedia.org/r/828519

gerritbot added a comment.Aug 31 2022, 1:09 PM

Change 828520 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] DM: Add type hints to StatementList

https://gerrit.wikimedia.org/r/828520

gerritbot added a comment.Aug 31 2022, 1:56 PM

Change 824256 abandoned by Ollie Shotton:

[mediawiki/extensions/Wikibase@master] [DNM] DM: Remove Statement deprecated functionality

Reason:

in favour of I179ffb3c421b5c01d59a2bd9d166f679e0441619

https://gerrit.wikimedia.org/r/824256

gerritbot added a comment.Aug 31 2022, 1:57 PM

Change 824257 abandoned by Ollie Shotton:

[mediawiki/extensions/Wikibase@master] [DNM] DM: Remove StatementList deprecated functionality

Reason:

in favour of I512680d99dedb761004e91fa1e4bc6e5b8bdfd8d

https://gerrit.wikimedia.org/r/824257

gerritbot added a comment.Aug 31 2022, 1:57 PM

Change 824281 abandoned by Ollie Shotton:

[mediawiki/extensions/Wikibase@master] [DNM] DM: Add type hints to Statement and StatementList

Reason:

in favour of I179ffb3c421b5c01d59a2bd9d166f679e0441619 and I512680d99dedb761004e91fa1e4bc6e5b8bdfd8d

https://gerrit.wikimedia.org/r/824281

gerritbot added a comment.Aug 31 2022, 1:58 PM

Change 824282 abandoned by Ollie Shotton:

[mediawiki/extensions/Wikibase@master] [DNM] DM: Remove explicit type checks

Reason:

in favour of I179ffb3c421b5c01d59a2bd9d166f679e0441619 and I512680d99dedb761004e91fa1e4bc6e5b8bdfd8d

https://gerrit.wikimedia.org/r/824282

gerritbot added a comment.Sep 2 2022, 10:44 AM

Change 828519 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] DM: Add type hints to Statement

https://gerrit.wikimedia.org/r/828519

gerritbot added a comment.Sep 2 2022, 10:44 AM

Change 828520 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] DM: Add type hints to StatementList

https://gerrit.wikimedia.org/r/828520

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 12) board.Sep 2 2022, 10:55 AM
ReleaseTaggerBot edited projects, added: MW-1.39-notes (1.39.0-wmf.28; 2022-09-05); removed: MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Sep 2 2022, 11:00 AM
Ollie.Shotton_WMDE updated the task description. (Show Details)Sep 2 2022, 1:56 PM
WMDE-leszek closed this task as Resolved.Oct 14 2022, 12:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits