Page MenuHomePhabricator
Create Task
Maniphest T314790

🟫 Reject statements that change the Statement ID
Closed, ResolvedPublic
Actions

Description

If the request contains id in the statement data, the API should respond with 400 (error code: invalid-operation-change-statement-id, error message: Cannot change the ID of the existing statement) unless the provided ID matches the the statement's ID in the request's path

Details

SubjectRepoBranchLines +/-
REST: Refactor Statement ID changed validationmediawiki/extensions/Wikibasemaster+13 -46
DM: Differentiate `replaceStatement()` exceptionsmediawiki/extensions/Wikibasemaster+82 -10
REST: Reject statements that change Statement IDmediawiki/extensions/Wikibasemaster+107 -5
REST: Reject statements that change Statement IDmediawiki/extensions/Wikibasemaster+118 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Aug 8 2022, 2:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2022, 2:49 PM
Jakob_WMDE renamed this task from Reject statements that change the Statement ID to 🟫 Reject statements that change the Statement ID.Aug 8 2022, 2:50 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)Aug 8 2022, 3:55 PM
Ollie.Shotton_WMDE claimed this task.Aug 8 2022, 4:22 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 11) board.
gerritbot added a comment.Aug 9 2022, 11:17 AM

Change 821701 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Reject statements that change Statement ID

https://gerrit.wikimedia.org/r/821701

gerritbot added a project: Patch-For-Review.Aug 9 2022, 11:17 AM
gerritbot added a comment.Aug 9 2022, 11:45 AM

Change 821704 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Reject statements that change Statement ID

https://gerrit.wikimedia.org/r/821704

gerritbot added a comment.Aug 9 2022, 12:42 PM

Change 821701 abandoned by Ollie Shotton:

[mediawiki/extensions/Wikibase@master] REST: Reject statements that change Statement ID

Reason:

Abandoning in favour of I4552a8f62608f1fcb482a1eeb8875563278c77cd

https://gerrit.wikimedia.org/r/821701

gerritbot added a comment.Aug 9 2022, 1:00 PM

Change 821704 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Reject statements that change Statement ID

https://gerrit.wikimedia.org/r/821704

Ollie.Shotton_WMDE added a comment.Aug 9 2022, 1:21 PM

Ended up doing use case validation as the alternative of catching exceptions thrown by the Data Model didn’t feel “right”.
We could raise an error in the Data Model as well as use case validation for a belt and braces approach; probably depends on how/where StatementList::replaceStatement() will be used in the future.

Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 11) board.Aug 9 2022, 1:22 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 9 2022, 1:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 9 2022, 2:00 PM
Ollie.Shotton_WMDE edited projects, added Wikibase Product Platform (v1) (Summer 2022 Not A Sprint); removed Wikibase Product Platform (v1) (Sprint 11).Aug 23 2022, 8:07 AM
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Summer 2022 Not A Sprint) board.
gerritbot added a comment.Aug 23 2022, 4:12 PM

Change 825826 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] DM: Differentiate `replaceStatement()` exceptions

https://gerrit.wikimedia.org/r/825826

gerritbot added a project: Patch-For-Review.Aug 23 2022, 4:12 PM

Change 825827 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Refactor Statement ID changed validation

https://gerrit.wikimedia.org/r/825827

Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Summer 2022 Not A Sprint) board.Aug 23 2022, 4:14 PM
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 12); removed Wikibase Product Platform (v1) (Summer 2022 Not A Sprint).Aug 24 2022, 10:41 AM
WMDE-leszek moved this task from To Do to Peer Review on the Wikibase Product Platform (v1) (Sprint 12) board.
gerritbot added a comment.Aug 25 2022, 8:16 AM

Change 825826 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] DM: Differentiate `replaceStatement()` exceptions

https://gerrit.wikimedia.org/r/825826

gerritbot added a comment.Aug 25 2022, 8:16 AM

Change 825827 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Refactor Statement ID changed validation

https://gerrit.wikimedia.org/r/825827

Ollie.Shotton_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 12) board.Aug 25 2022, 8:20 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 25 2022, 8:30 AM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.27; 2022-08-29); removed MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 25 2022, 9:00 AM
WMDE-leszek closed this task as Resolved.Oct 14 2022, 12:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL