Steps to replicate the issue (include links if applicable):
What happens?:
What should have happened instead?:
Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| QuickSurveys should not use mediawiki.Uri library | mediawiki/extensions/QuickSurveys | master | +32 -11 |
This is happening because the close button needs an aria-label (or :aria-hidden="true" if you want to hide it from SRs); see here for more info.
Here's an updated link to the guidelines available in the Codex docs on how to address this.
hi @Jdlrobson is this issue resolved ? if not , then could you assign it to me ?
Also i opened the https://en.wikipedia.beta.wmflabs.org/wiki/Dog?quicksurvey=true , i found no warning in the console
Change #1121113 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/extensions/QuickSurveys@master] QuickSurveys should not use mediawiki.Uri library