Page MenuHomePhabricator

[Vue warn on unit tests]: icon-only buttons require one of the following attribute: aria-label or aria-hidden.
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Run npm run test:unit

What happens?:

  • See several warnings

What should have happened instead?:

  • NO warnings

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

This is happening because the close button needs an aria-label (or :aria-hidden="true" if you want to hide it from SRs); see here for more info.

CCiufo-WMF subscribed.

Here's an updated link to the guidelines available in the Codex docs on how to address this.

hi @Jdlrobson is this issue resolved ? if not , then could you assign it to me ?
Also i opened the https://en.wikipedia.beta.wmflabs.org/wiki/Dog?quicksurvey=true , i found no warning in the console

Jdlrobson-WMF claimed this task.
Jdlrobson-WMF subscribed.

Thanks. Agree that this looks fixed. I presume these are now provided by default.

Jdlrobson-WMF renamed this task from [Vue warn]: icon-only buttons require one of the following attribute: aria-label or aria-hidden. to [Vue warn on unit tests]: icon-only buttons require one of the following attribute: aria-label or aria-hidden..Feb 24 2025, 6:17 PM
Jdlrobson-WMF reopened this task as Open.
Jdlrobson-WMF updated the task description. (Show Details)

Change #1121113 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/QuickSurveys@master] QuickSurveys should not use mediawiki.Uri library

https://gerrit.wikimedia.org/r/1121113

(Cannot replicate this anymore)