The original design of Add a Link had radioboxes to select one of several options for why a link was rejected. This was changed to checkboxes in T292592. Because of the flexibility available in the action_data payload, this only resulted in reject_reason changing from a single keyword to a comma-separated list of multiple keywords, similar to how reject_reasons works in the Add an Image schema. The schema documentation was not updated to reflect the change in the action_data payload, hence this task to update it.
Description
Description
Details
Details
Related Objects
Related Objects
- Mentioned Here
- T292592: Add a link: rejection reasons should be checkboxes
Event Timeline
Comment Actions
Change 821801 had a related patch set uploaded (by Nettrom; author: Nettrom):
[schemas/event/secondary@master] Update to reflect multiple possible rejection reasons
Comment Actions
Change 821801 merged by jenkins-bot:
[schemas/event/secondary@master] Update to reflect multiple possible rejection reasons
Comment Actions
Change 825916 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Bump link_suggestion_interaction schema version
Comment Actions
Change 825916 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Bump link_suggestion_interaction schema version
Comment Actions
@nettrom_WMF - the updates are in place; I checked the events logging in betalabs - please review the logging events look as it's expected.
(1) Not selecting any reason
- Clicking No
action: "suggestion_reject" action_data: "link_target=Slovanské jazyky;link_text=slovanských jazycích;probability_score=0.5837924480438232;series_number=0;rejection_reason=;acceptance_state=undecided" active_interface: "recommendedlinktoolbar_dialog"
action: "impression" action_data: "link_target=Slovanské jazyky;link_text=slovanských jazycích;probability_score=0.5837924480438232;series_number=0;rejection_reason=undefined;acceptance_state=rejected" active_interface: "rejection_dialog"
- clicking on Done (not selecting any reason)
action: "close" action_data: "link_target=Slovanské jazyky;link_text=slovanských jazycích;probability_score=0.5837924480438232;series_number=0;rejection_reason=;acceptance_state=rejected" active_interface: "rejection_dialog"
(2) Selecting only one reason (the first one)
- Clicking No
action: "suggestion_reject" action_data: "link_target=Anime;link_text=anime;probability_score=0.7713117003440857;series_number=2;rejection_reason=;acceptance_state=undecided" active_interface: "recommendedlinktoolbar_dialog"
action: "impression" action_data: "link_target=Anime;link_text=anime;probability_score=0.7713117003440857;series_number=2;rejection_reason=undefined;acceptance_state=rejected" active_interface: "rejection_dialog"
- Clicking the first reason and clicking on Done
action: "close" action_data: "link_target=Anime;link_text=anime;probability_score=0.7713117003440857;series_number=2;rejection_reason=everyday;acceptance_state=rejected" active_interface: "rejection_dialog"
(3) Selecting all reasons
- Clicking No
action: "suggestion_reject" action_data: "link_target=Personifikace;link_text=Personifikované;probability_score=0.5670402646064758;series_number=2;rejection_reason=;acceptance_state=undecided" active_interface: "recommendedlinktoolbar_dialog"
action: "impression" action_data: "link_target=Personifikace;link_text=Personifikované;probability_score=0.5670402646064758;series_number=2;rejection_reason=undefined;acceptance_state=rejected" active_interface: "rejection_dialog"
- selecting all reasons (and clicking Done)
action: "close" action_data: "link_target=Personifikace;link_text=Personifikované;probability_score=0.5670402646064758;series_number=2;rejection_reason=everyday,wrong-target,more-fewer-words,other;acceptance_state=rejected" active_interface: "rejection_dialog"
Comment Actions
The schema has been updated and the data that's flowing in is correct as far as I can tell, so this can be closed as resolved.