Page MenuHomePhabricator
Create Task
Maniphest T314947

Remove old refreshMessageBlobs.php script from WikimediaMaintenance
Closed, ResolvedPublic
Actions

Description

Follows-up T263872: Localisation cache must be purged after or during train deploy, not (just) before.

The WMF-specific extensions/WikimediaMaintenance/refreshMessageBlobs.php is now identical to core's purgeMessageBlobStore.php. There is no longer a use for the WMF-specific one to my knowledge.

According to Codesearch we have:

Details

SubjectRepoBranchLines +/-
Remove references to refreshMessageBlobs.phpoperations/mediawiki-configmaster+0 -1
Remove unused script refreshMessageBlobs.phpmediawiki/extensions/WikimediaMaintenancemaster+0 -18
Remove references to refreshMessageBlobs.phpmediawiki/tools/scapmaster+2 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Aug 10 2022, 5:19 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptAug 10 2022, 5:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle triaged this task as Medium priority.Aug 10 2022, 5:19 PM
Krinkle added a project: Technical-Debt.
Krinkle moved this task from Unsorted to Needs removal on the Technical-Debt board.
Reedy added a project: MediaWiki-extensions-WikimediaMaintenance.Aug 11 2022, 6:44 AM
RhinosF1 subscribed.Aug 11 2022, 7:36 AM
Krinkle moved this task from Inbox, needs triage to Radar on the Performance-Team board.Aug 15 2022, 7:11 PM
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.
Krinkle moved this task from Radar to Inbox, needs triage on the Performance-Team board.
Krinkle edited projects, added Performance-Team; removed Performance-Team (Radar).
Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Aug 15 2022, 7:22 PM

This is an easy task but touches numerous different repositories, teams, and deploy procedures. including Puppet (SRE) and wmf-config.

Krinkle added a parent task: T263872: Localisation cache must be purged after or during train deploy, not (just) before.Aug 22 2022, 4:44 PM
Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.Sep 8 2022, 2:24 PM
gerritbot added a comment.Sep 12 2022, 10:01 PM

Change 831628 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[mediawiki/tools/scap@master] Remove references to refreshMessageBlobs.php

https://gerrit.wikimedia.org/r/831628

gerritbot added a project: Patch-For-Review.Sep 12 2022, 10:01 PM
gerritbot added a comment.Sep 16 2022, 3:26 PM

Change 831628 merged by jenkins-bot:

[mediawiki/tools/scap@master] Remove references to refreshMessageBlobs.php

https://gerrit.wikimedia.org/r/831628

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2022, 3:30 PM
dancy updated the task description. (Show Details)Sep 16 2022, 3:53 PM

The changes to scap have been deployed to production and tested.

Krinkle edited projects, added MediaWiki-Engineering-Group-onboarding; removed Performance-Team, Scap.Aug 28 2023, 1:58 PM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptAug 28 2023, 1:58 PM
larissagaulia moved this task from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.Sep 4 2023, 11:04 AM
matmarex updated the task description. (Show Details)Dec 11 2023, 10:21 PM
gerritbot added a comment.Dec 11 2023, 10:24 PM

Change 982173 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/WikimediaMaintenance@master] Remove unused script refreshMessageBlobs.php

https://gerrit.wikimedia.org/r/982173

gerritbot added a project: Patch-For-Review.Dec 11 2023, 10:24 PM
Jdforrester-WMF updated the task description. (Show Details)Dec 11 2023, 10:28 PM
gerritbot added a comment.Dec 11 2023, 10:42 PM

Change 982173 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@master] Remove unused script refreshMessageBlobs.php

https://gerrit.wikimedia.org/r/982173

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 11 2023, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 11 2023, 11:10 PM
gerritbot added a comment.Dec 12 2023, 5:14 PM

Change 982441 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Remove references to refreshMessageBlobs.php

https://gerrit.wikimedia.org/r/982441

gerritbot added a project: Patch-For-Review.Dec 12 2023, 5:14 PM
matmarex updated the task description. (Show Details)Dec 12 2023, 5:15 PM
gerritbot added a comment.Dec 14 2023, 8:24 AM

Change 982441 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove references to refreshMessageBlobs.php

https://gerrit.wikimedia.org/r/982441

Stashbot added a comment.Dec 14 2023, 8:24 AM

Mentioned in SAL (#wikimedia-operations) [2023-12-14T08:24:42Z] <ariel@deploy2002> Started scap: Backport for [[gerrit:982441|Remove references to refreshMessageBlobs.php (T314947)]]

Stashbot added a comment.Dec 14 2023, 8:26 AM

Mentioned in SAL (#wikimedia-operations) [2023-12-14T08:26:11Z] <ariel@deploy2002> ariel and matmarex: Backport for [[gerrit:982441|Remove references to refreshMessageBlobs.php (T314947)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2023, 8:30 AM
Stashbot added a comment.Dec 14 2023, 8:35 AM

Mentioned in SAL (#wikimedia-operations) [2023-12-14T08:35:03Z] <ariel@deploy2002> Finished scap: Backport for [[gerrit:982441|Remove references to refreshMessageBlobs.php (T314947)]] (duration: 10m 20s)

matmarex closed this task as Resolved.Dec 14 2023, 10:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL