Page MenuHomePhabricator
Create Task
Maniphest T314963

[S] Ensure that mobile search results are not affected by desktop QuickView
Closed, ResolvedPublic
Actions

Description

For Milestone 2: MVP release of QuickView, the feature will be desktop only. This task is to ensure that QuickView is not accessible via mobile skin, and that special:search on mobile skin isn't affected in any way by the SearchVue extension until Milestone 3: Mobile Quickview is released.

Any existing QuickView code for mobile can stay to be used later as long as it does not affect Special:Search on mobile skin at all - this includes both UI and performance. If there is any affect whatsoever, the code will need to be removed (but can be kept locally for future use).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Ensure that mobile search results are not affected by desktop QuickViewmediawiki/extensions/SearchVuemaster+1 -2
Customize query in gerrit

Related Objects

Event Timeline

CBogen created this task.Aug 10 2022, 8:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2022, 8:49 PM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Aug 15 2022, 4:48 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
CBogen updated the task description. (Show Details)Aug 24 2022, 2:18 PM
CBogen renamed this task from Ensure that mobile search results are not affected by desktop QuickView to [S] Ensure that mobile search results are not affected by desktop QuickView.Aug 24 2022, 4:28 PM
CBogen updated the task description. (Show Details)Aug 24 2022, 4:55 PM
CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Aug 24 2022, 6:14 PM
SimoneThisDot claimed this task.Aug 25 2022, 7:40 PM
SimoneThisDot moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Aug 25 2022, 9:32 PM

Change 826666 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Ensure that mobile search results are not affected by desktop QuickView

https://gerrit.wikimedia.org/r/826666

gerritbot added a project: Patch-For-Review.Aug 25 2022, 9:32 PM
SimoneThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Aug 25 2022, 9:32 PM
gerritbot added a comment.Sep 7 2022, 10:38 AM

Change 826666 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Ensure that mobile search results are not affected by desktop QuickView

https://gerrit.wikimedia.org/r/826666

SimoneThisDot mentioned this in rESVU0987dd473564: Ensure that mobile search results are not affected by desktop QuickView.Sep 7 2022, 10:38 AM
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Sep 7 2022, 10:54 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 7 2022, 11:30 AM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Sep 12 2022, 11:01 PM
CBogen added a subscriber: Etonkovidova.Sep 14 2022, 3:39 PM

@Etonkovidova should we keep this in Needs QA until QuickView is deployed and can be tested on beta?

CBogen added a comment.Sep 14 2022, 3:55 PM
In T314963#8236546, @CBogen wrote:

@Etonkovidova should we keep this in Needs QA until QuickView is deployed and can be tested on beta?

Actually, maybe it's better to move this to Blocked until that point?

CBogen moved this task from Verify on Production to Blocked on the Structured-Data-Backlog (Current Work) board.Sep 14 2022, 3:58 PM

Blocked until the QuickView extension is deployed to beta cluster and this can be tested.

CBogen moved this task from Blocked to Needs QA on the Structured-Data-Backlog (Current Work) board.Oct 19 2022, 2:55 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Oct 31 2022, 11:38 PM

Checked on enwiki betalabs - the intro tour will be visible if a user performs a vertical scrolling - filed as T322091.

Etonkovidova closed this task as Resolved.Nov 30 2022, 11:48 PM

Checked on wmf.12 - works as expected.

CBogen reopened this task as Open.Dec 9 2022, 1:45 PM

@Etonkovidova I'm not sure how this was tested given that QuickView is not yet deployed on production?

Etonkovidova added a comment.Dec 16 2022, 10:54 PM
In T314963#8456788, @CBogen wrote:

@Etonkovidova I'm not sure how this was tested given that QuickView is not yet deployed on production?

I was checking two things

  • how mobile Special:Search performs when the desktop Special:Search is changed (the thumbnails are introduced)
  • and whatever code is added (merged), there is no effect on production UI

There were some issues on mobile due to the unexpected results of changing code for desktop.
T321348: [S] [minor] "Show thumbnails in Special:Search" option is available on mobile
T321362: [wmf.6 - regression] Mobile: non-media files thumbnails displayed incorrectly
T322091: [S] [betalabs - mobile] "Search Result Previews" intro tour is visible with horizontal scrolling

CBogen added a comment.Dec 19 2022, 2:14 PM

Okay, let's keep it open to check again on production that mobile isn't affected once Quickview is deployed there.

Etonkovidova closed this task as Resolved.Jan 6 2023, 12:59 AM

Checked (also with quickViewEnableMobile=1) - the QuickView was not present for the following cases:

  • the pilots wikis - idwiki, ptwiki, and ruwiki
  • some wikis where QuickView was not deployed to - enwiki, cswiki, and arwiki`
  • non-wikipedia sites - commons and wikiversity
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits